From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id C0B343858407; Thu, 7 Apr 2022 12:44:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C0B343858407 From: "aburgess at redhat dot com" To: gdb-prs@sourceware.org Subject: [Bug gdb/29032] [gdb][test-case failure, taskset] FAIL: gdb.base/eof-exit.exp: with non-dump terminal: close GDB with eof (timeout) Date: Thu, 07 Apr 2022 12:44:33 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: gdb X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: aburgess at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gdb-prs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-prs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 12:44:33 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D29032 --- Comment #8 from Andrew Burgess --- This also feels like an issue with readline's callback api. I wonder if we should (in parallel) be reporting this issue upstream? Pretty much untested, this patch seems to "fix" readline: diff --git a/readline/readline/readline.c b/readline/readline/readline.c index e61d188bbe9..1306ac7873d 100644 --- a/readline/readline/readline.c +++ b/readline/readline/readline.c @@ -630,7 +630,7 @@ readline_internal_charloop (void) previous character is interpreted as EOF. This doesn't work when READLINE_CALLBACKS is defined, so hitting a series of ^Ds will erase all the chars on the line and then return EOF. */ - if (((c =3D=3D _rl_eof_char && lastc !=3D c) || c =3D=3D EOF) && rl_= end =3D=3D 0) + if (((c =3D=3D _rl_eof_char && lastc !=3D c) || c =3D=3D EOF || c = =3D=3D 0) && rl_end =3D=3D 0) { #if defined (READLINE_CALLBACKS) RL_SETSTATE(RL_STATE_DONE); But I understand that we might want a solution in GDB (as well) that doesn't tie us to a particular readline release. I happy to take this to the readl= ine list, but I'd value your thoughts before I did. --=20 You are receiving this mail because: You are on the CC list for the bug.=