From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 217703858D28; Fri, 8 Apr 2022 13:17:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 217703858D28 From: "vries at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug gdb/29032] [gdb][test-case failure, taskset] FAIL: gdb.base/eof-exit.exp: with non-dump terminal: close GDB with eof (timeout) Date: Fri, 08 Apr 2022 13:17:26 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: gdb X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: vries at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gdb-prs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-prs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2022 13:17:27 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D29032 --- Comment #11 from Tom de Vries --- (In reply to Andrew Burgess from comment #8) > Pretty much untested, this patch seems to "fix" readline: >=20 > diff --git a/readline/readline/readline.c b/readline/readline/readline.c > index e61d188bbe9..1306ac7873d 100644 > --- a/readline/readline/readline.c > +++ b/readline/readline/readline.c > @@ -630,7 +630,7 @@ readline_internal_charloop (void) > previous character is interpreted as EOF. This doesn't work when > READLINE_CALLBACKS is defined, so hitting a series of ^Ds will > erase all the chars on the line and then return EOF. */ > - if (((c =3D=3D _rl_eof_char && lastc !=3D c) || c =3D=3D EOF) && r= l_end =3D=3D 0) > + if (((c =3D=3D _rl_eof_char && lastc !=3D c) || c =3D=3D EOF || c = =3D=3D 0) && > rl_end =3D=3D 0) > { > #if defined (READLINE_CALLBACKS) > RL_SETSTATE(RL_STATE_DONE); >=20 FWIW, I've tested this, and ran into: ... $ egrep '(UNRESOLVED|ERROR):' gdb.sum=20 ERROR: : spawn id exp49 not open UNRESOLVED: gdb.tui/basic.exp: scroll up ERROR: : spawn id exp49 not open UNRESOLVED: gdb.tui/basic.exp: scroll right ERROR: : spawn id exp49 not open UNRESOLVED: gdb.tui/basic.exp: scroll down ERROR: : spawn id exp49 not open UNRESOLVED: gdb.tui/basic.exp: asm window shows main ERROR: : spawn id exp49 not open UNRESOLVED: gdb.tui/basic.exp: split layout contents ERROR: : spawn id exp49 not open UNRESOLVED: gdb.tui/tui-layout-asm.exp: scroll to end of assembler (scroll failed) ... Specifically: ... PASS: gdb.tui/basic.exp: list -q main ^[[14;13H^[[2;16H^[[36mMERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.= =20 See the^[[3;13H GNU General Public License for more details.^[[4;13H^[[39m^[[0;10m^[[67X^[[5;16H^[[36mYou should have received a copy of the GNU General Public Licens^[[6;13H along with this program. If not, see ^[[34m