From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 869533858C53; Thu,  7 Apr 2022 10:00:13 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 869533858C53
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/29032] [gdb][test-case failure, taskset] FAIL:
 gdb.base/eof-exit.exp: with non-dump terminal: close GDB with eof (timeout)
Date: Thu, 07 Apr 2022 10:00:13 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: gdb
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-29032-4717-cmcqo8mIpI@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-29032-4717@http.sourceware.org/bugzilla/>
References: <bug-29032-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Apr 2022 10:00:13 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29032

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #3)
> This make the test-case pass reliably:

But, runs into trouble in the test-suite:
...
(gdb) ^M
100-gdb-set height 0^J100^done^M
(gdb) ^M
WARNING: Couldn't set the height to 0
101-gdb-set width 0^J101^done^M
(gdb) ^M
WARNING: Couldn't set the width to 0.
...
The change doesn't sit well with terminals used for mi input.

Now trying out moving the code to a place where it has less scope:
...
diff --git a/gdb/event-top.c b/gdb/event-top.c
index b628f0397cb..6fa0d492a2d 100644
--- a/gdb/event-top.c
+++ b/gdb/event-top.c
@@ -43,6 +43,7 @@
 #include "async-event.h"
 #include "bt-utils.h"
 #include "pager.h"
+#include "termios.h"

 /* readline include files.  */
 #include "readline/readline.h"
@@ -1312,6 +1313,11 @@ gdb_setup_readline (int editing)
      one instance of readline.  */
   if (ISATTY (ui->instream) && editing && ui =3D=3D main_ui)
     {
+      struct termios termios;
+      tcgetattr (0, &termios);
+      termios.c_lflag &=3D ~(ICANON);
+      tcsetattr (0, TCSANOW, &termios);
+
       /* Tell gdb that we will be using the readline library.  This
         could be overwritten by a command in .gdbinit like 'set
         editing on' or 'off'.  */
...

--=20
You are receiving this mail because:
You are on the CC list for the bug.=