public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug backtrace/29074] gdb fails to find a shared library for a function
Date: Sat, 26 Aug 2023 16:34:33 +0000	[thread overview]
Message-ID: <bug-29074-4717-861nuwSfnk@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29074-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29074

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9030a82d6f700e03ab143f0d002e9f21ae2fd52f

commit 9030a82d6f700e03ab143f0d002e9f21ae2fd52f
Author: Tom Tromey <tom@tromey.com>
Date:   Tue Aug 1 15:09:49 2023 -0600

    Use get_frame_address_in_block in print_frame

    The author of 'mold' pointed out that with a certain shared library,
    gdb would fail to find the shared library's name in 'bt'.

    The function in question appeared at the end of the .so's .text
    segment and ended with a call to 'abort'.

    This turned out to be a classic case of calling get_frame_pc when
    get_frame_address_in_block is needed -- the former will be off-by-one
    for purposes of finding the enclosing function or shared library.

    The included test fails without the patch on my system.  However, I
    imagine it can't be assumed to reliably fail.  Nevertheless it seemed
    worth doing.

    Regression tested on x86-64 Fedora 38.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29074
    Reviewed-by: Kevin Buettner <kevinb@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-08-26 16:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20  6:20 [Bug backtrace/29074] New: " rui314 at gmail dot com
2023-07-31 22:18 ` [Bug backtrace/29074] " tromey at sourceware dot org
2023-07-31 22:47 ` sam at gentoo dot org
2023-08-01 21:12 ` tromey at sourceware dot org
2023-08-03 17:18 ` tromey at sourceware dot org
2023-08-04 17:37 ` tromey at sourceware dot org
2023-08-26 16:34 ` cvs-commit at gcc dot gnu.org [this message]
2023-08-26 16:35 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29074-4717-861nuwSfnk@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).