From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 3291D3858C2C; Fri, 29 Apr 2022 19:52:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3291D3858C2C From: "tromey at sourceware dot org" To: gdb-prs@sourceware.org Subject: [Bug symtab/29106] New: new DWARF reader should de-duplicate functions Date: Fri, 29 Apr 2022 19:52:44 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: symtab X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: tromey at sourceware dot org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gdb-prs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-prs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2022 19:52:45 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D29106 Bug ID: 29106 Summary: new DWARF reader should de-duplicate functions Product: gdb Version: HEAD Status: NEW Severity: normal Priority: P2 Component: symtab Assignee: unassigned at sourceware dot org Reporter: tromey at sourceware dot org Target Milestone: --- In https://sourceware.org/pipermail/gdb-patches/2022-April/188400.html, Pedro pointed out that, even with the patch in that thread, the new DWARF reader still generates a larger index: In the old indexer, with an index of a gdb from before the indexer rewrite,= we had: [369902] intrusive_list >::begin: 9 [global, function] 255 [global, function] while in the new indexer, for the same function, we have: [369902] intrusive_list >::begin: 9 [global, function] 79 [global, function] 165 [global, function] 167 [global, function] [ ... many more instances ... ] I suspect this is due to the old handling of DW_AT_inline. See https://sourceware.org/pipermail/gdb-patches/2022-April/188557.html --=20 You are receiving this mail because: You are on the CC list for the bug.=