public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/29227] [gdb, m32] FAIL: gdb.base/corefile.exp: core-file warning-free
Date: Wed, 08 Jun 2022 07:37:25 +0000	[thread overview]
Message-ID: <bug-29227-4717-jP724hqsX6@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29227-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29227

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
This copies aforementioned code from elfcode.h:elf_object_p() to
elfcore.h:elf_core_file_p():
...
diff --git a/bfd/elfcore.h b/bfd/elfcore.h
index 809f6711aed..4ce81e2e383 100644
--- a/bfd/elfcore.h
+++ b/bfd/elfcore.h
@@ -272,6 +272,11 @@ elf_core_file_p (bfd *abfd)
       && ebd->elf_machine_code != EM_NONE)
     goto fail;

+  if (ebd->elf_machine_code != EM_NONE
+      && i_ehdrp->e_ident[EI_OSABI] != ebd->elf_osabi
+      && ebd->elf_osabi != ELFOSABI_NONE)
+    goto fail;
+
   /* Let the backend double check the format and override global
      information.  We do this before processing the program headers
      to allow the correct machine (as opposed to just the default
...
and fixes the FAIL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-06-08  7:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06  6:02 [Bug gdb/29227] New: " vries at gcc dot gnu.org
2022-06-06  6:06 ` [Bug gdb/29227] " vries at gcc dot gnu.org
2022-06-06  7:03 ` vries at gcc dot gnu.org
2022-06-06 18:14 ` vries at gcc dot gnu.org
2022-06-07  6:38 ` vries at gcc dot gnu.org
2022-06-08  7:37 ` vries at gcc dot gnu.org [this message]
2022-06-09  8:59 ` vries at gcc dot gnu.org
2024-01-05 15:36 ` ssbssa at sourceware dot org
2024-01-05 15:43 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29227-4717-jP724hqsX6@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).