[Bug tdep/29247] [gdb, tdep] ../../gdb/ppc-sysv-tdep.c:1945: internal-error: ppc64_sysv_abi_return_value: Assertion `ok' failed

["cel at us dot ibm.com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29247

Carl E Love <cel at us dot ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14167|0                           |1
        is obsolete|                            |

--- Comment #18 from Carl E Love <cel at us dot ibm.com> ---
Created attachment 14186
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14186&action=edit
Add IEEE support for float 128bit, version 3

Yes, the previous patch had { issues.  I split the patch into a functional
change patch and a debug print patch.  Unfortunately, I didn't get it done
cleanly as I found out later when I compiled just the functional patch.

The latest version merges the IEEE Float 128-bit and vector if clauses where
possible.  It updates ppc64_elfv2_abi_homogeneous_aggregate to support the IEEE
128-bit floating point.  That change fixes the rest of the issues with the
gdb.base/infcall-nested-structs-c.exp test.  The patch also fixes all of the
regression failures for gdb.base/infcall-nested-structs-c++.exp.

The current patch fixes 8 of the 9 failures in gdb.base/structs.exp.  The test
description for the one failing test is:  "Implemented by calling the one
parameter function "Fun$N" which stores its parameter in the global variable
"L$N".  GDB then examining that global to confirm that the value is as
expected."  

The test defines the global structures:
struct  struct1 {tA a;};
struct  struct2 {tA a; tB b;};
struct  struct3 {tA a; tB b; tC c; };
...
and
...
struct  struct1  foo1 = {'1'}, L1;
struct  struct2  foo2 = {'a','2'}, L2;
struct  struct3  foo3 = {'1','b','3'}, L3;
...

void Fun1(struct struct1 foo1)
{
  L1 = foo1;
}


The gdb test prints the value of L1 as follows:

p/c L1
$2 = {a = 0 '\000'}

(gdb) FAIL: gdb.base/structs.exp: types=tld: p/c L<n>; call 1 structs-tld

The tld indicates that the test is for the long double (IEEE Float 128-bit)
case.

Note, the test

p/c L2
$3 = {a = 97 'a', b = 50 '2'} 
(gdb) PASS: gdb.base/structs.exp: types=tld: p/c fun<n>(); call 2 structs-tld

passes.  The print for the global values do not appear to use any of the
functions in gdb/ppc-sysv-tdep.c.  I have yet to find how gdb handles the
global variable case.  I haven't seen anything yet in the ABI about it either. 
Any hints on where the issue is for the global case would be appreciated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.