From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id DD490383D80A; Sat, 25 Jun 2022 00:42:51 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DD490383D80A
From: "cel at us dot ibm.com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tdep/29247] [gdb, tdep] ../../gdb/ppc-sysv-tdep.c:1945:
 internal-error: ppc64_sysv_abi_return_value: Assertion `ok' failed
Date: Sat, 25 Jun 2022 00:42:51 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: tdep
X-Bugzilla-Version: 12.1
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cel at us dot ibm.com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created
Message-ID: <bug-29247-4717-v3yDA6gLSt@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-29247-4717@http.sourceware.org/bugzilla/>
References: <bug-29247-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Jun 2022 00:42:52 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29247

Carl E Love <cel at us dot ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14164|0                           |1
        is obsolete|                            |

--- Comment #16 from Carl E Love <cel at us dot ibm.com> ---
Created attachment 14167
  --> https://sourceware.org/bugzilla/attachment.cgi?id=3D14167&action=3Ded=
it
Add IEEE support for float 128bit, version 2



> The only thing that looks wrong to me is the condition in (new) line 1440=
.  It
> seems that this erroneously no longer handles any float/double values at =
all
> anymore.

I think you are referring to this section of code?


-  if (type->code () =3D=3D TYPE_CODE_FLT
+  /* IBM long double uses floating point registers for the 128-bit value. =
 */
+  if ((type->code () =3D=3D TYPE_CODE_FLT
+       && !(gdbarch_long_double_format (gdbarch)
+           =3D=3D floatformats_ieee_quad) && TYPE_LENGTH (type) =3D=3D 16)
       || type->code () =3D=3D TYPE_CODE_DECFLOAT)
     {

I was trying to make sure that the IEEE 128-bit case would be excluded.  I
think it was only taking that one case out.  But, it is hard to read.  I
rewrote it to make it easier to read.  By checking for the IEEE FLOAT 128-b=
it
case first, then TYPE_CODE_FLT you don't need to modify the existing "if
(type->code () =3D=3D TYPE_CODE_FLT" statement.

I also found I had missed handling a float case.  I fixed that it reduced t=
he
number of errors from 72 to 12.  I am not sure about the check for aggregate
candidate and homogeneous aggregate.  Not sure yet what a homogeneous
float/vector is and if I need to do something special to check for them in =
the
case of the IEEE FLOAT 128-bit case?

Attached latest patch.  It has a comments indicating the new code.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=