public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/29257] Double free of demangled symbol name
Date: Tue, 06 Dec 2022 18:42:07 +0000	[thread overview]
Message-ID: <bug-29257-4717-LiabYEAXRg@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29257-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29257

--- Comment #7 from Tom Tromey <tromey at sourceware dot org> ---
> - Mark minimal symbols as read (objfile->per_bfd->minsyms_read = true) as soon as elf_read_minimal_symbols has completed. I'm not confident about this. There could be some other state that must also have been completed before we want to set this to true?

I think the problem with this is that minsyms are implemented weirdly.
There may be multiple sources of minsyms in a given objfile.
Now, probably how this should be done is each reader should make
its own object.  However, what's actually done is that they all
write to the same basic data structure, so it isn't marked as
completed until the very end.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-12-06 18:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16 16:41 [Bug gdb/29257] New: " mhov at undo dot io
2022-06-16 18:07 ` [Bug gdb/29257] " mhov at undo dot io
2022-06-18 16:29 ` tromey at sourceware dot org
2022-06-23 13:53 ` mhov at undo dot io
2022-06-23 14:05 ` mhov at undo dot io
2022-06-23 16:43 ` amerey at redhat dot com
2022-06-24 16:16 ` mhov at undo dot io
2022-12-06 18:42 ` tromey at sourceware dot org [this message]
2022-12-06 19:01 ` tromey at sourceware dot org
2022-12-06 19:07 ` tromey at sourceware dot org
2022-12-07 20:55 ` amerey at redhat dot com
2022-12-09 17:55 ` mhov at undo dot io
2022-12-12 18:40 ` tromey at sourceware dot org
2023-04-13 17:46 ` tromey at sourceware dot org
2023-04-13 20:00 ` cvs-commit at gcc dot gnu.org
2023-04-13 20:00 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29257-4717-LiabYEAXRg@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).