public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug record/29260] New: Stopped event should contain reason for 'No more reverse-execution history'
@ 2022-06-17 17:35 trass3r at gmail dot com
2022-06-17 20:58 ` [Bug record/29260] " trass3r at gmail dot com
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: trass3r at gmail dot com @ 2022-06-17 17:35 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29260
Bug ID: 29260
Summary: Stopped event should contain reason for 'No more
reverse-execution history'
Product: gdb
Version: unknown
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: record
Assignee: unassigned at sourceware dot org
Reporter: trass3r at gmail dot com
Target Milestone: ---
When stepping past the reverse execution history buffer bounds
gdb prints 'No more reverse-execution history' to the output but does not give
a reason in the MI stopped event, leading to a bad UX.
https://github.com/microsoft/MIEngine/pull/1037#issuecomment-750299377
1: (62155) <-1057-exec-next --reverse
1: (62156) ->1057^running
1: (62156) ->*running,thread-id="1"
1: (62156) ->(gdb)
1: (62163) ->~"\nNo more reverse-execution history.\n"
1: (62164) ->~"main (argc=1, argv=0x7fffffffdb78) at ../test.cpp:25\n"
1: (62164) ->~"25\t\tstd::u16string s = u\"test\";\n"
1: (62164)
->*stopped,frame={addr="0x000055555555734b",func="main",args=[{name="argc",value="1"},{name="argv",value="0x7fffffffdb78"}],file="../test.cpp",fullname="/tmp/test.cpp",line="25",arch="i386:x86-64"},thread-id="1",stopped-threads="all",core="2"
Test case:
https://github.com/microsoft/MIEngine/pull/1037#issuecomment-1158743492
int main()
{
int i = 0;
++i;
++i;
return i;
}
$ gdb --batch -ex 'b main' -ex r -ex n -ex 'p i' -ex 'record full' -ex n -ex 'p
i' -ex n -ex 'p i' -ex n -ex 'p i' -ex 'reverse-next' -ex 'p i' -ex
'reverse-next' -ex 'p i' -ex 'reverse-next' -ex 'p i' test
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug record/29260] Stopped event should contain reason for 'No more reverse-execution history'
2022-06-17 17:35 [Bug record/29260] New: Stopped event should contain reason for 'No more reverse-execution history' trass3r at gmail dot com
@ 2022-06-17 20:58 ` trass3r at gmail dot com
2022-06-18 16:20 ` tromey at sourceware dot org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: trass3r at gmail dot com @ 2022-06-17 20:58 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29260
--- Comment #1 from trass3r <trass3r at gmail dot com> ---
Code of interest:
handle_inferior_event(infrun.c:5858):
case TARGET_WAITKIND_NO_HISTORY:
/* Reverse execution: target ran out of history info. */
/* Switch to the stopped thread. */
context_switch (ecs);
infrun_debug_printf ("stopped");
delete_just_stopped_threads_single_step_breakpoints ();
ecs->event_thread->set_stop_pc
(regcache_read_pc (get_thread_regcache (inferior_thread ())));
if (handle_stop_requested (ecs))
return;
gdb::observers::no_history.notify (); // just prints the line in
print_no_history_reason
stop_waiting (ecs);
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug record/29260] Stopped event should contain reason for 'No more reverse-execution history'
2022-06-17 17:35 [Bug record/29260] New: Stopped event should contain reason for 'No more reverse-execution history' trass3r at gmail dot com
2022-06-17 20:58 ` [Bug record/29260] " trass3r at gmail dot com
@ 2022-06-18 16:20 ` tromey at sourceware dot org
2022-06-18 17:08 ` trass3r at gmail dot com
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2022-06-18 16:20 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29260
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org
Status|UNCONFIRMED |NEW
Last reconfirmed| |2022-06-18
Ever confirmed|0 |1
--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
FWIW I think there may be other cases where a stop reason is missing.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug record/29260] Stopped event should contain reason for 'No more reverse-execution history'
2022-06-17 17:35 [Bug record/29260] New: Stopped event should contain reason for 'No more reverse-execution history' trass3r at gmail dot com
2022-06-17 20:58 ` [Bug record/29260] " trass3r at gmail dot com
2022-06-18 16:20 ` tromey at sourceware dot org
@ 2022-06-18 17:08 ` trass3r at gmail dot com
2022-06-18 17:09 ` trass3r at gmail dot com
2023-01-18 13:49 ` blarsen at redhat dot com
4 siblings, 0 replies; 6+ messages in thread
From: trass3r at gmail dot com @ 2022-06-18 17:08 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29260
--- Comment #3 from trass3r <trass3r at gmail dot com> ---
I also saw https://sourceware.org/bugzilla/show_bug.cgi?id=15072 about reverse
finish with breakpoints. But that's about the whole stopped event missing.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug record/29260] Stopped event should contain reason for 'No more reverse-execution history'
2022-06-17 17:35 [Bug record/29260] New: Stopped event should contain reason for 'No more reverse-execution history' trass3r at gmail dot com
` (2 preceding siblings ...)
2022-06-18 17:08 ` trass3r at gmail dot com
@ 2022-06-18 17:09 ` trass3r at gmail dot com
2023-01-18 13:49 ` blarsen at redhat dot com
4 siblings, 0 replies; 6+ messages in thread
From: trass3r at gmail dot com @ 2022-06-18 17:09 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29260
trass3r <trass3r at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://sourceware.org/bugz
| |illa/show_bug.cgi?id=15072
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug record/29260] Stopped event should contain reason for 'No more reverse-execution history'
2022-06-17 17:35 [Bug record/29260] New: Stopped event should contain reason for 'No more reverse-execution history' trass3r at gmail dot com
` (3 preceding siblings ...)
2022-06-18 17:09 ` trass3r at gmail dot com
@ 2023-01-18 13:49 ` blarsen at redhat dot com
4 siblings, 0 replies; 6+ messages in thread
From: blarsen at redhat dot com @ 2023-01-18 13:49 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29260
B. Larsen <blarsen at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |blarsen at redhat dot com
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from B. Larsen <blarsen at redhat dot com> ---
Commit 37f54063ed0daaffbd52f69efbdb4c8e0a9c9cca gdb/mi: add no-history stop
reason fixed this bug (but I forgot to reference this bug, oops). It is fixed
on master now.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-18 13:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-17 17:35 [Bug record/29260] New: Stopped event should contain reason for 'No more reverse-execution history' trass3r at gmail dot com
2022-06-17 20:58 ` [Bug record/29260] " trass3r at gmail dot com
2022-06-18 16:20 ` tromey at sourceware dot org
2022-06-18 17:08 ` trass3r at gmail dot com
2022-06-18 17:09 ` trass3r at gmail dot com
2023-01-18 13:49 ` blarsen at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).