public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/29286] SUMMARY: ThreadSanitizer: data race gdb/dwarf2/read.c:4100 in dw_expand_symtabs_matching_file_matcher
Date: Sat, 25 Jun 2022 16:19:15 +0000	[thread overview]
Message-ID: <bug-29286-4717-SqU1qgNWUP@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29286-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29286

--- Comment #9 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to Tom de Vries from comment #7)
> Created attachment 14171 [details]
> gdb.log
> 
> While testing, found another one.
> 
> Replicating the same fix works for the test-case:
> ...
> diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
> index 6e581a6a8ea..f1a5b71b66e 100644
> --- a/gdb/dwarf2/read.c
> +++ b/gdb/dwarf2/read.c
> @@ -4280,6 +4280,11 @@
> dwarf2_base_index_functions::find_pc_sect_compunit_symtab
>      warning (_("(Internal error: pc %s in read in CU, but not in symtab.)"),
>              paddress (objfile->arch (), pc));
>  
> +  cooked_index_vector *table
> +    = (static_cast<cooked_index_vector *>
> +       (per_objfile->per_bfd->index_table.get ()));
> +  table->wait ();
> +
>    result = recursively_find_pc_sect_compunit_symtab
>      (dw2_instantiate_symtab (data, per_objfile, false), pc);

This will probably have to be a new override method in
cooked_index_functions that waits and then calls the
superclass method.  The base functions can't assume
there is a cooked index.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-06-25 16:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-25  9:19 [Bug gdb/29286] New: " vries at gcc dot gnu.org
2022-06-25  9:19 ` [Bug gdb/29286] " vries at gcc dot gnu.org
2022-06-25  9:20 ` vries at gcc dot gnu.org
2022-06-25  9:57 ` vries at gcc dot gnu.org
2022-06-25 11:10 ` vries at gcc dot gnu.org
2022-06-25 11:29 ` vries at gcc dot gnu.org
2022-06-25 12:14 ` vries at gcc dot gnu.org
2022-06-25 12:26 ` tromey at sourceware dot org
2022-06-25 14:17 ` vries at gcc dot gnu.org
2022-06-25 16:03 ` vries at gcc dot gnu.org
2022-06-25 16:17 ` tromey at sourceware dot org
2022-06-25 16:19 ` tromey at sourceware dot org [this message]
2022-06-25 20:33 ` vries at gcc dot gnu.org
2022-06-25 21:26 ` vries at gcc dot gnu.org
2022-06-25 22:38 ` vries at gcc dot gnu.org
2022-06-26 13:16 ` vries at gcc dot gnu.org
2022-06-26 13:36 ` vries at gcc dot gnu.org
2022-06-28  5:47 ` vries at gcc dot gnu.org
2022-06-28  5:48 ` vries at gcc dot gnu.org
2022-06-28 12:38 ` vries at gcc dot gnu.org
2022-06-29 13:12 ` vries at gcc dot gnu.org
2022-06-29 15:34 ` vries at gcc dot gnu.org
2022-07-12 14:59 ` vries at gcc dot gnu.org
2022-07-13 17:01 ` tromey at sourceware dot org
2022-07-14  7:10 ` vries at gcc dot gnu.org
2022-07-14  7:13 ` vries at gcc dot gnu.org
2022-07-14 18:50 ` vries at gcc dot gnu.org
2022-07-14 18:53 ` vries at gcc dot gnu.org
2022-09-23 20:44 ` tromey at sourceware dot org
2022-09-24  5:39 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29286-4717-SqU1qgNWUP@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).