[Bug gdb/29295] [gdb] out of bounds access in objfile::section_offset

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29295

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
This fixes the assert:
...
diff --git a/gdb/symfile.c b/gdb/symfile.c
index 6f546f5b059..04b00a0ec9b 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -3579,8 +3579,12 @@ default_symfile_relocate (struct objfile *objfile,
asection *se
ctp,
       sect->output_section = sect;
       sect->output_offset = 0;
     }
-
-  return bfd_simple_get_relocated_section_contents (abfd, sectp, buf, NULL);
+  int old = bfd_count_sections (abfd);
+  bfd_byte *res = bfd_simple_get_relocated_section_contents (abfd, sectp, buf,
NULL
);
+  for (int i = old; i < bfd_count_sections (abfd); ++i)
+    objfile->section_offsets.insert (objfile->section_offsets.begin () + i,
+                                    (CORE_ADDR)0);
+  return res;
 }

 /* Relocate the contents of a debug section SECTP in ABFD.  The
...

I'm not sure if (CORE_ADDR)0 is the right value, but I'm not sure where to find
a better value.

Also, I suppose more data need updating than just section_offsets.

Finally, I'm not sure if this is a good place to fix it.  Maybe we should
define a _new_section_hook and use that instead?

-- 
You are receiving this mail because:
You are on the CC list for the bug.