From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 78F773858430; Sat,  9 Jul 2022 09:17:09 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 78F773858430
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/29343] [gdb/symtab] per_cu->length set without
 initial_length_size
Date: Sat, 09 Jul 2022 09:17:09 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: symtab
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-29343-4717-2lwSIrwyv2@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-29343-4717@http.sourceware.org/bugzilla/>
References: <bug-29343-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Jul 2022 09:17:09 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29343

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Created attachment 14200
  --> https://sourceware.org/bugzilla/attachment.cgi?id=3D14200&action=3Ded=
it
tentative patch

This patch fixes the one use:
...
-      this_cu->length =3D cu_header.length + cu_header.initial_length_size;
+      this_cu->length =3D cu_header.get_length ();
...
and then proceeds to make the length field private, to enforce using the
accessor.

That works reasonably well, but runs into trouble with this memset:
...
@@ -23377,8 +23377,6 @@ dwarf2_per_cu_data::get_header () const
       const gdb_byte *info_ptr
        =3D this->section->buffer + to_underlying (this->sect_off);

-      memset (&m_header, 0, sizeof (m_header));
-
       read_comp_unit_head (&m_header, info_ptr, this->section,
                           rcuh_kind::COMPILE);

...
which I removed in the patch, but I'm not sure yet that correct.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=