public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/29381] [gdb, debug-types, debug-names] read.h:309: internal-error: set_length: Assertion `m_length == length' failed.
Date: Tue, 19 Jul 2022 10:24:11 +0000	[thread overview]
Message-ID: <bug-29381-4717-47UjYmGhGl@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29381-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29381

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #2)
> Zooming in on the actual assert, we have:

This fixes the length discrepancy:
...
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 143bcfb5374..490cc3dd0b2 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -4590,7 +4590,8 @@ create_cus_from_debug_names_list (dwarf2_per_bfd
*per_bfd,
                                  dwarf2_section_info &section,
                                  bool is_dwz)
 {
-  if (!map.augmentation_is_gdb)
+  if (!map.augmentation_is_gdb
+      || (map.tu_count > 0 && per_bfd->types.size () == 0))
     {
       for (uint32_t i = 0; i < map.cu_count; ++i)
        {
...
and makes the assert disappear.

But in combination with the "[gdbsupport] Use task size in parallel_for_each"
patch we run instead into:
...
/home/vries/gdb_versions/devel/src/gdb/dwarf2/read.h:298: internal-error:
length: Assertion `m_length != 0' failed.
...
because we still have those duplicates.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-07-19 10:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19  7:59 [Bug symtab/29381] New: " vries at gcc dot gnu.org
2022-07-19  8:36 ` [Bug symtab/29381] " vries at gcc dot gnu.org
2022-07-19 10:02 ` vries at gcc dot gnu.org
2022-07-19 10:24 ` vries at gcc dot gnu.org [this message]
2022-07-19 11:34 ` vries at gcc dot gnu.org
2022-07-19 13:14 ` vries at gcc dot gnu.org
2022-07-19 16:50 ` vries at gcc dot gnu.org
2022-07-19 17:36 ` vries at gcc dot gnu.org
2022-07-22 21:52 ` vries at gcc dot gnu.org
2022-08-01 12:04 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29381-4717-47UjYmGhGl@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).