From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 8CD533858D28; Tue, 26 Jul 2022 14:47:33 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8CD533858D28
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tdep/29409] [gdb, tdep/aarch64] FAIL:
 gdb.opt/inline-small-func.exp: info breakpoints
Date: Tue, 26 Jul 2022 14:47:33 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: tdep
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-29409-4717-3AFZSpGZqb@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-29409-4717@http.sourceware.org/bugzilla/>
References: <bug-29409-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jul 2022 14:47:33 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29409

--- Comment #11 from Tom de Vries <vries at gcc dot gnu.org> ---
Another regression, test-case gdb.base/store.exp, insns:
...
00000000004005e4 <add_charest>:
  4005e4:       13001c02        sxtb    w2, w0
  4005e8:       13001c20        sxtb    w0, w1
  4005ec:       12001c41        and     w1, w2, #0xff
  4005f0:       12001c00        and     w0, w0, #0xff
  4005f4:       0b000020        add     w0, w1, w0
  4005f8:       12001c00        and     w0, w0, #0xff
  4005fc:       13001c00        sxtb    w0, w0
  400600:       d65f03c0        ret
...
and lines:
...
CU: store.c:
File name                   Line number    Starting address    View    Stmt
store.c                              14            0x4005e4               x
store.c                              15            0x4005ec               x
store.c                              16            0x400600               x
...

Without the patch, we use skip_prologue_using_sal and return 0x4005ec and
consequently line 15, which is the expected one.

With the patch, we return 0x4005e4 and consequently line 14.

Intesting question: are the two first insns part of the prologue or not?

In GCC terms, they come after NOTE_INSN_PROLOGUE_END but before
NOTE_INSN_FUNCTION_BEG and consequently have line info markers for the open=
ing
brace '{' at line 14.

You could argue that this is a gcc bug and that the insn at 0x4005e4 should
have line 15, so something like this:
...
store.c                              14            0x4005e4               x
store.c                              15            0x4005e4               x
store.c                              16            0x400600               x
...
AFAIU, this would get us line 15 both with and without the patch.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=