From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 53CCE3858005; Wed,  7 Sep 2022 13:46:10 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 53CCE3858005
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1662558370;
	bh=JSok/nFfGvZDZOqYOHi/b7sipzsq9fkmg25OfYaMzk4=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=D24KWnCuKJ761QFAZQnqrLBnr6O6hj0W7L+XbHyVu+MaTOPuj6znWFqY+6mH/K5+I
	 ptRo8mpc30gPlOn1hgtaTRPBIhKNHomRsJEL2CVWX6yjQouSrVbzNiZ2aOF4m4wt9q
	 /pzyMxGQEEFDC6zG5Y9w+qlHAXCn/Zprvb5aI62Y=
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tdep/29543] [gdb/tdep, ppc] inferior call with long double
 vararg not handled correctly
Date: Wed, 07 Sep 2022 13:46:09 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: tdep
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-29543-4717-KeHLlZjez0@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-29543-4717@http.sourceware.org/bugzilla/>
References: <bug-29543-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29543

--- Comment #10 from Tom de Vries <vries at gcc dot gnu.org> ---
Created attachment 14320
  --> https://sourceware.org/bugzilla/attachment.cgi?id=3D14320&action=3Ded=
it
tentative patch

(In reply to Ulrich Weigand from comment #9)
> (In reply to Tom de Vries from comment #8)
> > (In reply to Ulrich Weigand from comment #7)
> > > Note it would appear the same problem also exists when handling homog=
eneous
> > > (ELFv2) or single-element (ELFv1) aggregates: these also need 16-byte
> > > alignment if the base type is a vector or _Float128 type.
> >=20
> > Can you or Carl propose a patch for this additional problem?
>=20
> It's just a few lines further down in the same function, in the final else
> branch:
>=20
>   else
>     {
>       ppc64_sysv_abi_push_val (gdbarch, val, TYPE_LENGTH (type), 0, argpo=
s);
> [...]
>=20
> followed by either ppc64_sysv_abi_push_vreg or ppc64_sysv_abi_push_freg.
>=20
> The problem is that alignment of 0 is only correct in those cases where
> ppc64_sysv_abi_push_freg is called - in those cases where
> ppc64_sysv_abi_push_vreg is called, we also need to use 16 byte alignment
> here.
>=20

Like this?

I've also added a test-case, but I haven't been able to try this on ppc64le
yet.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=