From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 528593858CDA; Thu, 29 Sep 2022 02:23:22 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 528593858CDA
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1664418202;
	bh=io3ovb+Lzbsvq0eakHNIxR4DKX4tgmQwkuJBXBpyJ8c=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=Hp6gGGnblB4BfrtEEpyNrCrGJvKZ+Cux+lzimw3B/kf8oi6QVomlx5+gPGvws/lpy
	 0mIzgN6xoknuL1cW2xsybk5AencKgkVRzoxwPeX7f0QNX+vT5r6qQnfv3MoSLtVU1U
	 1Dq8pc2VhTT49aj4G5/JYPAmi6SJRnAZH5kc7vLU=
From: "amerey at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug cli/29582] Usability improvement: CTRL+C when debugindod client
 is downloading a file
Date: Thu, 29 Sep 2022 02:23:21 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: cli
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: amerey at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-29582-4717-xq7RGb3Lyu@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-29582-4717@http.sourceware.org/bugzilla/>
References: <bug-29582-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29582

--- Comment #8 from Aaron Merey <amerey at redhat dot com> ---
(In reply to Tom de Vries from comment #7)
> Created attachment 14367 [details]
> tentative patch

Thanks for the patch, I think this works nicely. I just have a couple
suggestions regarding some of the wording.=20

> +      if (debuginfod_cancel =3D=3D debuginfod_ask)
> +	{
> +	  int resp =3D nquery (_("Cancel further downloading for this session? =
"));
> +	  if (resp)
> +	    debuginfod_cancel =3D debuginfod_all;
> +	  else
> +	    debuginfod_cancel =3D debuginfod_one;
> +	}
> +      if (debuginfod_cancel =3D=3D debuginfod_all)
> +	{
> +	  gdb_printf (_("Debuginfod has been disabled.\n"));

Here it could be useful to include instructions for how to re-enable
debuginfod. Something like:=20
"Debuginfod has been disabled. To re-enable use the 'set debuginfod enabled=
 on'
command."

> +  add_setshow_enum_cmd ("cancel", class_run, debuginfod_cancel_enum,
> +			_("Set cancellation mode for debuginfod."),
> +			_("Show cancellation mode for debuginfod."),
> +			_("\
> +When set to one, ^C cancels a single download.\n\
> +When set to all, ^C cancels all further downloads.\n\
> +When set to ask, ^C asks what to do."),

To be extra clear about what the cancellation mode is I'd add the following
line:

The cancellation mode controls the behavior of ^C while a file is downloadi=
ng
from debuginfod.\n\
When set to one, ^C cancels a single download.\n\
...

--=20
You are receiving this mail because:
You are on the CC list for the bug.=