public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug testsuite/29664] [gdb/testsuite, taskset -c 0] FAIL: gdb.base/style.exp: capture_command_output for x/1i *main
Date: Mon, 10 Oct 2022 09:38:29 +0000	[thread overview]
Message-ID: <bug-29664-4717-kUi8WrmDQ2@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29664-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29664

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
A minimal reproducer:
...
$ cat gdb/testsuite/gdb.base/style.exp 
load_lib gdb-python.exp

clean_restart

gdb_py_test_silent_cmd \
    [multi_line_input \
         "python" \
         "\004"] \
    "python, ^D" \
    true

set command "print 1"

set test "capture_command_output for $command"

set re_command [string_to_regexp ${command}]
gdb_test_multiple "$command" "$test - match command" {
    -re "^$re_command\r\n" {
        pass $gdb_test_name
    }
}

gdb_test_multiple "" "$test - match output" {
    -re "^(\[^\r\n\]+\r\n)" {
        exp_continue
    }
    -re "^$gdb_prompt $" {
        pass $gdb_test_name
    }
}
...

I think there's a bug in the fact that we're handling a single command output
using two gdb_test_multiples.

But I think the root cause here is another one: we're using
gdb_py_test_silent_cmd to send a command ending in ^D, but doing so adds a "\n"
at the end.

This fixes it:
...
set command \
    [multi_line_input \
         "python" \
         "\004"]
send_gdb $command
gdb_py_test_silent_cmd \
    "" \
    "python, ^D" \
    true
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2022-10-10  9:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10  8:58 [Bug testsuite/29664] New: " vries at gcc dot gnu.org
2022-10-10  9:38 ` vries at gcc dot gnu.org [this message]
2022-10-10  9:41 ` [Bug testsuite/29664] " vries at gcc dot gnu.org
2022-10-10 10:24 ` vries at gcc dot gnu.org
2022-10-10 10:27 ` vries at gcc dot gnu.org
2022-10-10 10:33 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29664-4717-kUi8WrmDQ2@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).