public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug testsuite/29674] [gdb/testsuite] Test-cases untested due to "missing .note.GNU-stack section implies executable stack"
Date: Wed, 12 Oct 2022 04:54:45 +0000	[thread overview]
Message-ID: <bug-29674-4717-tkRbYEg7SR@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29674-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29674

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
This also fixes it:
...
diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp
index b85ec290299..11f73af01ee 100644
--- a/gdb/testsuite/lib/dwarf.exp
+++ b/gdb/testsuite/lib/dwarf.exp
@@ -3283,6 +3283,8 @@ namespace eval Dwarf {

        _write_deferred_output

+       _section .note.GNU-stack "" progbits
+
        if { $file_id == "" } {
            catch {close $_output_file}
        }
...

Though for some reason % is used instead of @:
...
        .section .note.GNU-stack, "", %progbits
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2022-10-12  4:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12  4:47 [Bug testsuite/29674] New: " vries at gcc dot gnu.org
2022-10-12  4:54 ` vries at gcc dot gnu.org [this message]
2022-10-12 15:52 ` [Bug testsuite/29674] " vries at gcc dot gnu.org
2022-10-27 15:17 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29674-4717-tkRbYEg7SR@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).