public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug python/29712] [gdb, aarch64] UNRESOLVED: gdb.python/py-disasm.exp: global_disassembler=ReadMemoryGdbErrorDisassembler: disassemble test Date: Fri, 21 Oct 2022 13:09:38 +0000 [thread overview] Message-ID: <bug-29712-4717-wV1A7Pzsr0@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-29712-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=29712 Tom de Vries <vries at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aburgess at redhat dot com --- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> --- I tried to reproduce this using: ... $ ./build/gdb/gdb -q -batch -ex "set trace-commands on" -x outputs/gdb.python/py-disasm/gdb.in.1 ... but didn't manage because some disasm commands fail, so I tried to prefix all disasm commands using ignore-errors ( https://sourceware.org/pipermail/gdb-patches/2021-May/178990.html ), but found that that still stopped script execution. I was able to repair this by doing: ... diff --git a/gdb/disasm.c b/gdb/disasm.c index de44aac3263..b1ba119db9e 100644 --- a/gdb/disasm.c +++ b/gdb/disasm.c @@ -454,7 +454,7 @@ gdb_pretty_print_disassembler::pretty_print_insn (const struct disasm_insn *insn object destructor as the write itself might throw an exception if the pager kicks in, and the user selects quit. */ write_out_insn_buffer (); - throw ex; + throw; } if ((flags & (DISASSEMBLY_RAW_INSN | DISASSEMBLY_RAW_BYTES)) != 0) ... It's possible that the ignore-errors code should try harder to catch errors, but this change doesn't look wrong. -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2022-10-21 13:09 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-21 10:47 [Bug python/29712] New: " vries at gcc dot gnu.org 2022-10-21 13:09 ` vries at gcc dot gnu.org [this message] 2022-10-21 13:43 ` [Bug python/29712] " vries at gcc dot gnu.org 2022-10-21 14:11 ` vries at gcc dot gnu.org 2022-10-21 14:18 ` vries at gcc dot gnu.org 2022-10-21 20:54 ` aburgess at redhat dot com 2022-10-22 4:31 ` vries at gcc dot gnu.org 2022-10-24 9:17 ` vries at gcc dot gnu.org 2022-10-24 12:51 ` aburgess at redhat dot com 2022-10-31 18:17 ` brobecker at gnat dot com 2022-11-02 7:12 ` luis.machado at arm dot com 2022-11-28 19:24 ` cvs-commit at gcc dot gnu.org 2022-11-28 19:24 ` cvs-commit at gcc dot gnu.org 2022-12-01 18:10 ` tromey at sourceware dot org 2022-12-02 16:39 ` aburgess at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-29712-4717-wV1A7Pzsr0@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).