public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "tomas.vanek at fbl dot cz" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug tdep/29716] Arm v8 M-profile FNC_RETURN unwinder uses wrong stack Date: Fri, 04 Nov 2022 18:01:09 +0000 [thread overview] Message-ID: <bug-29716-4717-YpZawFcv58@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-29716-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=29716 --- Comment #4 from tomas.vanek at fbl dot cz --- (In reply to Torbjörn SVENSSON from comment #3) > > I have not been able to reproduce this issue after applying below patch > series. Maybe they are still there, maybe they are indirectly fixed. > https://sourceware.org/pipermail/gdb-patches/2022-November/193391.html > > @Tomas, can you take a look at them and see if it resolves the issues you've > seen? Tested with the patch series and all 3 problems persist. > Regarding the use of CONTROL.SPSEL instead of the xspr value; you can't use > CONTROL as it's not stacked on EXC_RETURN/FNC_RETURN and to my knowledge, > it's not part of the DWARF2 info either. Oh yes, I suspected it. The only viable solution for FNC_RETURN seems me to use CONTROL_S from the actual CPU register. Typically the SPSEL bit is set at the app initialisation and then kept unchanged, so it will mostly work - at least unwinding will be less broken than without any use of SPSEL. Similarly we can use CONTROL_NS for return from secure to non-secure. There is tricky to detect the security state change. I made some code to address both interstate directions. I will modify it for the latest arm-tdep.c with your patch series and send to patches ml. -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2022-11-04 18:01 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-21 20:59 [Bug tdep/29716] New: " tomas.vanek at fbl dot cz 2022-10-29 10:47 ` [Bug tdep/29716] " tomas.vanek at fbl dot cz 2022-10-29 15:43 ` tomas.vanek at fbl dot cz 2022-11-04 15:36 ` torbjorn.svensson at st dot com 2022-11-04 18:01 ` tomas.vanek at fbl dot cz [this message] 2022-11-04 18:24 ` tomas.vanek at fbl dot cz 2022-11-04 20:54 ` tomas.vanek at fbl dot cz 2022-11-05 9:50 ` tomas.vanek at fbl dot cz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-29716-4717-YpZawFcv58@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).