public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "libin.dang at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/29742] [ARMv7] [gdbserver] maybe_hw_step: Assertion `has_single_step_breakpoints (thread)' failed.
Date: Fri, 10 Feb 2023 14:50:56 +0000	[thread overview]
Message-ID: <bug-29742-4717-G1JPhx6Euk@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29742-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29742

--- Comment #10 from Libin Dang <libin.dang at gmail dot com> ---
It seems this issue can be fixed by the following change:

diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc
index 7e1de39..6639f6e 100644
--- a/gdbserver/linux-low.cc
+++ b/gdbserver/linux-low.cc
@@ -2460,16 +2460,11 @@ linux_process_target::resume_stopped_resumed_lwps
(thread_info *thread)
       && !lp->status_pending_p
       && thread->last_status.kind () == TARGET_WAITKIND_IGNORE)
     {
-      int step = 0;
-
-      if (thread->last_resume_kind == resume_step)
-       step = maybe_hw_step (thread);
-
-      threads_debug_printf ("resuming stopped-resumed LWP %s at %s: step=%d",
+      threads_debug_printf ("resuming stopped-resumed LWP %s at %s",
                            target_pid_to_str (ptid_of (thread)).c_str (),
-                           paddress (lp->stop_pc), step);
+                           paddress (lp->stop_pc));

-      resume_one_lwp (lp, step, GDB_SIGNAL_0, NULL);
+      proceed_one_lwp (thread, NULL);
     }
 }

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2023-02-10 14:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 15:50 [Bug gdb/29742] New: " libin.dang at gmail dot com
2022-11-03  8:32 ` [Bug gdb/29742] " luis.machado at arm dot com
2022-11-03 15:33 ` libin.dang at gmail dot com
2022-11-03 16:45 ` luis.machado at arm dot com
2022-11-10 10:35 ` libin.dang at gmail dot com
2022-11-10 10:37 ` libin.dang at gmail dot com
2022-11-10 10:45 ` libin.dang at gmail dot com
2022-11-21 16:25 ` libin.dang at gmail dot com
2022-11-29 13:19 ` jeroen.hiddink at vialis dot nl
2023-02-10 14:45 ` libin.dang at gmail dot com
2023-02-10 14:47 ` libin.dang at gmail dot com
2023-02-10 14:50 ` libin.dang at gmail dot com [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29742-4717-G1JPhx6Euk@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).