[Bug record/29745] New: gdbserver doesn't record changing return address on call instructions

["blarsen at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29745

            Bug ID: 29745
           Summary: gdbserver doesn't record changing return address on
                    call instructions
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: record
          Assignee: unassigned at sourceware dot org
          Reporter: blarsen at redhat dot com
  Target Milestone: ---

Created attachment 14431
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14431&action=edit
minimal test

When running an inferior in the gdbserver in x86_64, the call instruction only
saves the register changes to $PC and possible parameters, it does not save the
change to the return address in the stack.

This makes it so when trying to next over a function or finish a function, GDB
sets a breakpoint on the wrong address, and may skip multiple functions instead
of just the expected one.

As an example, running the attached test I get the following output:

Temporary breakpoint 1, main () at
testsuite/outputs/gdb.reverse/step-reverse/step-reverse.c:10
10        foo ();
(gdb) record
(gdb) n
11        int x = 0;
(gdb) 
12        foo ();
(gdb) 
13        return 0;
(gdb) rn
12        foo ();
(gdb) 
11        int x = 0;
(gdb) 

No more reverse-execution history.
main () at testsuite/outputs/gdb.reverse/step-reverse/step-reverse.c:10
10        foo ();
(gdb) n

No more reverse-execution history.
main () at testsuite/outputs/gdb.reverse/step-reverse/step-reverse.c:13
13        return 0;

Notice that the final line is 13 when it should be line 11.

-- 
You are receiving this mail because:
You are on the CC list for the bug.