[Bug sim/29752] sim:frv: -Wincompatible-function-pointer-types build failure: sem.c:24343:41: error: incompatible function pointer types passing 'void (SIM_CPU *, UINT, UDI)' to parameter of type 'void (*)(SIM_CPU *, UINT, DI)'

["vapier at gentoo dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29752

Mike Frysinger <vapier at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|sim: build failure with     |sim:frv:
                   |Clang 16                    |-Wincompatible-function-poi
                   |(-Wincompatible-function-po |nter-types build failure:
                   |inter-types,                |sem.c:24343:41: error:
                   |-Wimplicit-function-declara |incompatible function
                   |tion)                       |pointer types passing 'void
                   |                            |(SIM_CPU *, UINT, UDI)' to
                   |                            |parameter of type 'void
                   |                            |(*)(SIM_CPU *, UINT, DI)'
             Target|                            |frv-elf

--- Comment #9 from Mike Frysinger <vapier at gentoo dot org> ---
i think all -Wimplicit-function-declaration issues are fixed

the only -Wincompatible-function-pointer-types issue left is frv and its
sem.c/queue logic.

sem.c:24343:41: error: incompatible function pointer types passing 'void
(SIM_CPU *, UINT, UDI)' (aka 'void (struct _sim_cpu *, unsigned int, unsigned
long)') to parameter of type 'void (*)(SIM_CPU *, UINT, DI)' (aka 'void
(*)(struct _sim_cpu *, unsigned int, long)')
[-Wincompatible-function-pointer-types]

sem.c is generated by CGEN code.  not really sure where in the scheme files
this comes from.  but it's all related to a call like:
  sim_queue_fn_di_write (current_cpu, frvbf_h_acc40U_set, ...

sim_queue_fn_di_write wants a func that has a param of (SIM_CPU*, UINT, DI),
but frvbf_h_acc40U_set has a UDI.  there isn't a sim_queue_fn_udi_write helper.

we could change frvbf_h_acc40U_set to take a DI instead of UDI ?  in practice,
i don't think the sign is checked ?  not sure tbh.  and we don't have much of
an FRV maintainer atm.

-- 
You are receiving this mail because:
You are on the CC list for the bug.