From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 076043858C00; Wed, 18 Jan 2023 19:02:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 076043858C00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674068538; bh=0ocyWjo1w8uvNONU2aq5sqaEBSxpbGaHiCm714cshiY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Z+qQguZsguguWU5roQzBqOG2x1q4mgpPI5lpoTp7w9abMXxRPV7Zfv1ndzUADChYR N7ZTd5CojnTalv5oVPCdCGAV65Xv5OR/B8azLVA6jyxn5siFnWgrzUXQ75MIQiegP4 CXymIILFLVyoVzQcA6Fcg933Mo2dUfPdyzEqPv6g= From: "tromey at sourceware dot org" To: gdb-prs@sourceware.org Subject: [Bug testsuite/29778] [gdb/testsuite] Revise untested usage Date: Wed, 18 Jan 2023 19:02:17 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: testsuite X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: tromey at sourceware dot org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D29778 Tom Tromey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tromey at sourceware dot o= rg --- Comment #8 from Tom Tromey --- I wasn't aware of this bug when I wrote the "require" series. I also stumbled over the weird text in dejagnu that made me that "untested" was essentially useless. So, I changed require to use unsupported. On reflection though, I think what dejagnu says isn't super important. We can just pick the one we like for gdb. I tend to think the noise is fine. My reasoning is that these procs give us a way to see not just that a test didn't run, but also why it didn't run. Occasionally this reason could be surprising and lead to some kind of bug fix. So my view is that the silent "return"s in the test cases should be converted. Centralizing these decisions with "require" or other "do task and return on failure" procs makes this simpler to achieve. (Here I was thinking of prepare_for_testing but it looks like build_executable can call untested.) One other way centralizing is nice is that if we decide to remove the noise, we can just remove these calls and be done. --=20 You are receiving this mail because: You are on the CC list for the bug.=