public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "ro at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug build/29791] [13 regression] Many gdbsupport files don't compile on Solaris
Date: Fri, 18 Nov 2022 12:50:47 +0000	[thread overview]
Message-ID: <bug-29791-4717-sBsU5AaU03@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29791-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29791

--- Comment #5 from Rainer Orth <ro at gcc dot gnu.org> ---
(In reply to Tom Tromey from comment #3)
> I found this: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101747
> which points out a problem with the 2-argument form of
> the malloc attribute.

I'd found this myself, but forgotten about it.  I've meanwhile reported the
current failure in that PR: let's see what we get from that.

> Unfortunately the error messages here don't tell us enough to know
> where the ambiguous use occurs.  They just refer back to the macro
> itself -- but we want the spot where it is invoked.  Normally GCC
> shows this.

Indeed: that's why I couldn't really make sense of the error, and failed to
produce a reduced testcase.

> I also don't know the correct fix.  The opacity here is one of the
> issues with using gnulib, IMO.  Maybe reaching out to them is the
> best thing to do.  Meanwhile, especially just before the GDB 13
> release, I'm reasonably fine with a workaround like the one you have.

My current feeling is to wait with a gnulib bug report until I hear from the
GCC side: otherwise, there's probably not much what they can do about the
problem.

> Our gnulib import has a way to automate application of a patch
> when doing a new import.  See gnulib/update-gnulib.sh and
> gnulib/patches/.  I guess you should do something along those
> lines.

Thanks, that got me started.  I've a patch ready along those lines that I will
post shortly.

Thanks.
  Rainer

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-11-18 12:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 14:41 [Bug build/29791] New: " ro at gcc dot gnu.org
2022-11-16 14:42 ` [Bug build/29791] " ro at gcc dot gnu.org
2022-11-16 14:43 ` ro at gcc dot gnu.org
2022-11-16 14:44 ` ro at gcc dot gnu.org
2022-11-16 19:21 ` tromey at sourceware dot org
2022-11-17  9:55 ` cvs-commit at gcc dot gnu.org
2022-11-18 12:50 ` ro at gcc dot gnu.org [this message]
2022-11-18 13:10 ` ro at gcc dot gnu.org
2022-11-20 14:15 ` ro at gcc dot gnu.org
2022-11-26 14:09 ` brobecker at gnat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29791-4717-sBsU5AaU03@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).