From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 9FA5A39960E1; Thu, 17 Nov 2022 13:11:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9FA5A39960E1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668690700; bh=6d9j7gBBD8ChvpBEkt+bH9JFXgSeg3sx0GyJJfBHV8k=; h=From:To:Subject:Date:In-Reply-To:References:From; b=He0PtgxgRE5mafbdHd+c2k4LlkNTttEvmzGeqH1rBTDiRXTYKO+aFmbJNu5qU/dTZ KBKIBTqg/DIXvGwE8InA3lbRjyFpI2Fhx6KeeAbKS3aHpdE/IX/slbwaf3gpfI/fFy +f+Ks6GFrNCHgbEGSNQcI6lSeVN05gL+uaIWiTSo= From: "uweigand at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug tdep/29793] [gdb/tdep, powerpc] FAIL: gdb.cp/gdb2495.exp: call a function that raises an exception without a handler. Date: Thu, 17 Nov 2022 13:11:40 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: tdep X-Bugzilla-Version: 12.1 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: uweigand at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D29793 Ulrich Weigand changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ulrich.weigand at de dot ibm.com |uweigand at gcc dot= gnu.org --- Comment #8 from Ulrich Weigand --- This is all quite a mess, it would appear. There's many callers of create_internal_breakpoint that want to set a breakpoint at the start of a function that is looked up via name as an msymbol. These really should all= do the same thing, but right now there's many different variants. I believe the most general sequence that should work on all targets would b= e to use, in this order: - gdbarch_convert_from_func_ptr_addr (convert from a function descriptor address to a text address) - gdbarch_addr_bits_remove (remove ISA marker bits in the address) - gdbarch_deprecated_function_start_offset (only used on VAX - seems redundant with either convert_from_func_ptr_add= r or skip_entrypoint, and should probably be removed) - gdbarch_skip_entrypoint (select the entrypoint to set a breakpoint on) I think it would be good to use some appropriate abstraction that makes sure these steps are followed in all those cases where we want to set an internal breakpoint on a function by name, but I'm not sure what this is exactly. --=20 You are receiving this mail because: You are on the CC list for the bug.=