[Bug build/29798] symtab.c doesn't compile with 32-bit GCC 12

["simon.marchi at polymtl dot ca" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29798

Simon Marchi <simon.marchi at polymtl dot ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.marchi at polymtl dot ca

--- Comment #2 from Simon Marchi <simon.marchi at polymtl dot ca> ---
(In reply to Rainer Orth from comment #0)
> Compiling symtab.c with a 32-bit GCC 12 (12.2.0 on Solaris 11.4 in my case)
> fails like this:
> 
> /vol/src/gnu/gdb/hg/master/local/gdb/symtab.c: In member function
> ‘std::vector<symbol_search> global_symbol_searcher::search() const’:
> /vol/src/gnu/gdb/hg/master/local/gdb/symtab.c:4961:44: error: ‘std::sprintf’
> may write a terminating nul past the end of the destination
> [-Werror=format-overflow=]
>  4961 |               sprintf (tmp, "operator%.*s%s", fix, " ", opname);
>       |                                            ^
> /vol/src/gnu/gdb/hg/master/local/gdb/symtab.c:4961:23: note: ‘std::sprintf’
> output between 9 and 2147483648 bytes into a destination of size 2147483647
>  4961 |               sprintf (tmp, "operator%.*s%s", fix, " ", opname);
>       |               ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> I'm uncertain how best to address this.

Use string_printf to make it an std::string.

-- 
You are receiving this mail because:
You are on the CC list for the bug.