[Bug tdep/29814] [gdb/tdep, powerpc64le] FAIL: gdb.base/msym-bp-shl.exp: debug=0: before run: info breakpoint

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29814

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cel at us dot ibm.com,
                   |                            |ulrich.weigand at de dot ibm.com

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
This is a more generic fix:
...
diff --git a/gdb/ppc-linux-tdep.c b/gdb/ppc-linux-tdep.c
index cc5a26431ba..f7a7703e01e 100644
--- a/gdb/ppc-linux-tdep.c
+++ b/gdb/ppc-linux-tdep.c
@@ -1662,6 +1662,14 @@ ppc_elfv2_skip_entrypoint (struct gdbarch *gdbarch,
CORE_ADDR pc)
   if (fun.minsym == NULL)
     return pc;

+  const char *name = fun.minsym->linkage_name ();
+  const char *atsign = strchr (name, '@');
+  bool is_at_symbol = atsign != nullptr && atsign > name;
+  bool is_plt = is_at_symbol && strcmp (atsign, "@plt") == 0;
+
+  if (is_plt)
+    return pc;
+
   /* See ppc_elfv2_elf_make_msymbol_special for how local entry point
      offset values are encoded.  */
   if (fun.minsym->target_flag_1 ())
...

Not great to do the string comparison here, but I'm not sure what else to do.

I saw:
...
 0x0000000070000000 (PPC64_GLINK)        0x9fc
...
and:
...
00000000000009e8 <__glink_PLTresolve>:
 9e8:   a6 02 08 7c     mflr    r0
  ...
 a18:   20 04 80 4e     bctr

0000000000000a1c <__cxa_finalize@plt>:
 a1c:   cc ff ff 4b     b       9e8 <__glink_PLTresolve>

0000000000000a20 <__libc_start_main@plt>:
 a20:   c8 ff ff 4b     b       9e8 <__glink_PLTresolve>

0000000000000a24 <__gmon_start__@plt>:
 a24:   c4 ff ff 4b     b       9e8 <__glink_PLTresolve>

0000000000000a28 <foo@plt>:
 a28:   c0 ff ff 4b     b       9e8 <__glink_PLTresolve>

Disassembly of section .fini:

0000000000000a2c <_fini>:
...

So maybe we can compare the address to PPC64_GLINK, and if it's bigger than
that and in the text section we can consider it plt?

-- 
You are receiving this mail because:
You are on the CC list for the bug.