public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug testsuite/29816] [gdb/testsuite, powerpc64le] FAIL: gdb.ada/float-bits.exp: print 16llf#4000921fb54442d18469898cc51701b8#
Date: Thu, 01 Dec 2022 06:25:09 +0000	[thread overview]
Message-ID: <bug-29816-4717-oH5S3bKG0K@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29816-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29816

--- Comment #11 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=32a5aa2625686a709b22db19300a578d96285dd1

commit 32a5aa2625686a709b22db19300a578d96285dd1
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Dec 1 07:25:04 2022 +0100

    [gdb/testsuite] Fix gdb.ada/float-bits.exp for powerpc64le

    On powerpc64le-linux, I run into:
    ...
    (gdb) print 16llf#4000921fb54442d18469898cc51701b8#^M
    $9 = <invalid float value>^M
    (gdb) FAIL: gdb.ada/float-bits.exp: print \
      16llf#4000921fb54442d18469898cc51701b8#
    ...

    The problem is that we're using a hex string for the 128-bit IEEE quad long
    double format, but the actual long double float format is:
    ...
    gdbarch_dump: long_double_format = floatformat_ibm_long_double_little^M
    ...

    Fix this by using the hex string obtained by compiling test.c:
    ...
    long double a = 5.0e+25L;
    ...
    like so:
    ...
    $ gcc -mlittle test.c -c -g
    ...
    and running gdb:
    ...
    $ gdb -q -batch test.o -ex "p /x a"
    $1 = 0xc1e1c000000000004544adf4b7320335
    ...
    and likewise for -mbig:
    ...
    $ gdb -q -batch test.o -ex "p /x a"
    $1 = 0x4544adf4b7320335c1e1c00000000000
    ...

    Tested on powerpc64le-linux.

    I excercised the case of floatformat_ibm_long_double_big by
    using "set endian big" in the test-case.

    Note that for this patch to work correctly, recent commit aaa79cd62b8
("[gdb]
    Improve printing of float formats") is required.

    PR testsuite/29816
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29816
    Approved-By: Tom Tromey <tom@tromey.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-12-01  6:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 14:10 [Bug tdep/29816] New: [gdb/tdep, " vries at gcc dot gnu.org
2022-11-21 17:45 ` [Bug tdep/29816] " vries at gcc dot gnu.org
2022-11-21 17:50 ` vries at gcc dot gnu.org
2022-11-21 18:00 ` vries at gcc dot gnu.org
2022-11-23 11:21 ` [Bug testsuite/29816] [gdb/testsuite, " vries at gcc dot gnu.org
2022-11-23 16:01 ` tromey at sourceware dot org
2022-11-23 17:01 ` vries at gcc dot gnu.org
2022-11-23 22:26 ` cel at us dot ibm.com
2022-11-24  6:27 ` vries at gcc dot gnu.org
2022-11-24 13:00 ` vries at gcc dot gnu.org
2022-11-30 14:00 ` vries at gcc dot gnu.org
2022-12-01  6:25 ` cvs-commit at gcc dot gnu.org [this message]
2022-12-01  6:27 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29816-4717-oH5S3bKG0K@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).