[Bug gdb/29854] ^C should interrupt synchronous wait on cooked index completion

["simark at simark dot ca" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29854

--- Comment #5 from Simon Marchi <simark at simark dot ca> ---
(In reply to Tom Tromey from comment #4)
> Created attachment 14484 [details]
> patch
> 
> I couldn't really test this, but maybe you can?

It works.

For fun, I added a "maintenance wait-finalize" command, that does:

static void
maintenance_wait_finalize (const char *args, int from_tty)
{
  inferior *inf = current_inferior ();

  for (objfile *o : inf->pspace->objfiles ())
    {
      dwarf_scanner_base *s
        = get_dwarf2_per_objfile (o)->per_bfd->index_table.get ();
      cooked_index_vector *v = dynamic_cast<cooked_index_vector *> (s);
      if (!v)
        continue;

      printf("Waiting for %s\n", objfile_name (o));
      v->wait ();
    }
}

This way, I can measure how much time GDB takes to make the index with:

$ /usr/bin/time ./gdb -nx -q --data-directory=data-directory
testsuite/outputs/gdb.gdb/selftest/xgdb -ex "maint wait-finalize" -batch

With my unoptimized build, it takes about 30 seconds.  With my optimized build
(on the same binary), it takes 2 seconds.  I noticed this, because I would
start gdb.gdb/selftest.exp, then try to interrupt with ^C during the "break
captured_main" command, and runtest would hang for a while, waiting for the GDB
process to exit.

So, it's not really important to fix this, but it fixes an annoyance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.