From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 02B0C385514B; Mon, 12 Dec 2022 13:51:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 02B0C385514B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670853062; bh=qzzT1z1sGBXZRLgeEMmzRB6TvgkTKXjdTuKVjR92HBU=; h=From:To:Subject:Date:In-Reply-To:References:From; b=E9P03s6y9R/3HFtPbNHhcyKaGhRYtuik5PmtoGG1hcuQdwDNcsFF+ikCcHqDfi3yT LWeMfLVS8OTQrBKoWFgDnaPnf7fi0CC82vbD2LrHEU1w2IsGddrJuIsD9nU66aWZ3B M32bNgFVUgp1ENCsej9WOFapg3TmY8sw/wNyEzIs= From: "uweigand at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug tdep/29868] [gdb/tdep, s390x] breakpoint.c:5784: internal-error: bpstat_stop_status_nowatch: Assertion `!target_stopped_by_watchpoint ()' Date: Mon, 12 Dec 2022 13:51:01 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: tdep X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: uweigand at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D29868 Ulrich Weigand changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |uweigand at gcc dot gnu.org --- Comment #6 from Ulrich Weigand --- Thanks for the investigation! The GDB code to "Do not report this watchpoint again" was added back in 200= 7 as part of this patch series: https://sourceware.org/pipermail/gdb-patches/2007-September/052502.html https://sourceware.org/pipermail/gdb-patches/2007-September/052503.html and back then, it probably worked as expected. The kernel ptrace implementation was changed to prohibit modifying those bi= ts only in 2011 as part of some generic cleanup and tightening of access rules= .=20 At that point, we probably missed that it broke GDB. I agree that the TRAP_HWBKPT check looks correct - several other platforms = have an equivalent check, so I think the patch is fine. (Longer term, I'm wonde= ring if this check shouldn't move to Linux generic code then?) However, I think we should then *also* remove the "Do not report this watchpoint again" ptrace call - no sense in having this in if it doesn't wo= rk anyway; it just wastes time and confuses anyone reading that code. --=20 You are receiving this mail because: You are on the CC list for the bug.=