From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 36DB3385C659; Mon, 12 Dec 2022 15:08:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 36DB3385C659 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670857734; bh=Gdsc02hwGb1c6noy86Q31jWfSS65gYBdsUvv4Kdya4Q=; h=From:To:Subject:Date:In-Reply-To:References:From; b=NgGQFLG6azMJXsFf2n3/fRTm2NUdclwFvQYyM44VNI9oc5etxa4BLTtSnpw9OG7dm wQ3I3jtGJG40K4XikeQxLER+kzhhhGBe7aEjZ6afSQ6+ZM27372PfNO90d335A1Kn0 YjzvhFnCluDc4jWvBJhg+uDtRHsxSbp5ETb6PnfE= From: "vries at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug tdep/29868] [gdb/tdep, s390x] breakpoint.c:5784: internal-error: bpstat_stop_status_nowatch: Assertion `!target_stopped_by_watchpoint ()' Date: Mon, 12 Dec 2022 15:08:53 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: tdep X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: vries at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D29868 --- Comment #7 from Tom de Vries --- (In reply to Ulrich Weigand from comment #6) > Thanks for the investigation! >=20 Np :) > The GDB code to "Do not report this watchpoint again" was added back in 2= 007 > as part of this patch series: > https://sourceware.org/pipermail/gdb-patches/2007-September/052502.html > https://sourceware.org/pipermail/gdb-patches/2007-September/052503.html > and back then, it probably worked as expected. >=20 > The kernel ptrace implementation was changed to prohibit modifying those > bits only in 2011 as part of some generic cleanup and tightening of access > rules. At that point, we probably missed that it broke GDB. >=20 Ack. > I agree that the TRAP_HWBKPT check looks correct - several other platforms > have an equivalent check, so I think the patch is fine. (Longer term, I'm > wondering if this check shouldn't move to Linux generic code then?) >=20 > However, I think we should then *also* remove the "Do not report this > watchpoint again" ptrace call - no sense in having this in if it doesn't > work anyway; it just wastes time and confuses anyone reading that code. I've submitted a patch implementing that approach at https://sourceware.org/pipermail/gdb-patches/2022-December/194635.html --=20 You are receiving this mail because: You are on the CC list for the bug.=