public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug c++/29896] GDB git doesn't recognize template function name
Date: Tue, 13 Dec 2022 19:33:52 +0000	[thread overview]
Message-ID: <bug-29896-4717-8MPnrnFxWv@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29896-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29896

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
What happens is that the first scan (the cooked index) takes
the name from the DWARF and gets "t0<>".  The cooked index
just uses strncasecmp to find entries, so it doesn't find
this name.

Full symbol name matching, I think, is done with strncmp_iw_with_mode,
which handles a lot of weird cases and ignores the "<>":

      /* Skip template parameters in STRING1 if STRING2 does not contain
         any.  E.g.:
[...]

So, that sucks.

I'm not completely sure how to solve it.  Perhaps stripping
the template parmaeters before recording the entry in the index would
work.

One idea is to have two entries, both with and without the parameters,
but I wonder about combinatorial explosion if there are nested templates
like a<>::b<>::c<>::d<> -- since the entries record parent information.

Another idea is to change the hashing and the lookup to use
strncmp_iw_with_mode somehow, at least for C++ names.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-12-13 19:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13  2:05 [Bug c++/29896] New: " vimacs.hacks at gmail dot com
2022-12-13  3:21 ` [Bug c++/29896] " simark at simark dot ca
2022-12-13  3:32 ` vimacs.hacks at gmail dot com
2022-12-13 19:33 ` tromey at sourceware dot org [this message]
2022-12-14  0:42 ` tromey at sourceware dot org
2022-12-15 14:28 ` tromey at sourceware dot org
2022-12-15 17:37 ` tromey at sourceware dot org
2022-12-15 19:08 ` tromey at sourceware dot org
2023-01-17 14:06 ` cvs-commit at gcc dot gnu.org
2023-01-17 14:15 ` cvs-commit at gcc dot gnu.org
2023-01-17 14:15 ` tromey at sourceware dot org
2023-01-18 22:08 ` tromey at sourceware dot org
2023-02-02  3:38 ` brobecker at gnat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29896-4717-8MPnrnFxWv@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).