[Bug gdb/29941] Inferior call strlen(p) gives segfaults in GDB 13, (somewhat?) works in GDB11 and GDB12

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29941

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=08fd407675396cf9500519f02033e6cec270a4a6

commit 08fd407675396cf9500519f02033e6cec270a4a6
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Tue Jan 3 10:18:48 2023 +0100

    [gdb] Fix segfault during inferior call to ifunc

    With a simple test-case:
    ...
    $ cat test.c
    char *p = "a";
    int main (void) {
      return strlen (p);
    }
    $ gcc -g test.c
    ...
    we run into this segfault:
    ...
    $ gdb -q -batch a.out -ex start -ex "p strlen (p)"
    Temporary breakpoint 1 at 0x1151: file test.c, line 4.
    [Thread debugging using libthread_db enabled]
    Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

    Temporary breakpoint 1, main () at test.c:4
    4         return strlen (p);

    Fatal signal: Segmentation fault
    ...

    The strlen is an ifunc, and consequently during the call to
    call_function_by_hand_dummy for "p strlen (p)" another call
    to call_function_by_hand_dummy is used to resolve the ifunc.

    This invalidates the get_current_frame () result in the outer call.

    Fix this by using prepare_reinflate and reinflate.

    Note that this series (
   
https://inbox.sourceware.org/gdb-patches/20221214033441.499512-1-simon.marchi@polymtl.ca/
)
    should address this problem, but this patch is a simpler fix which is easy
to
    backport.

    Tested on x86_64-linux.

    Co-Authored-By: Tom de Vries <tdevries@suse.de>
    PR gdb/29941
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29941

-- 
You are receiving this mail because:
You are on the CC list for the bug.