public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/29962] FAIL: gdb.reverse/step-reverse.exp: reverse step into fn call
Date: Thu, 12 Jan 2023 11:55:29 +0000	[thread overview]
Message-ID: <bug-29962-4717-JXdV6BeSwv@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29962-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29962

--- Comment #7 from Tom de Vries <vries at gcc dot gnu.org> ---
This passes gdb.reverse/*.exp:
...
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 181d961d80d..ba0b10de965 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -6900,11 +6900,12 @@ process_event_stop_test (struct execution_control_state
*ecs)
       if (stop_pc == ecs->event_thread->control.step_range_start
          && stop_pc != ecs->stop_func_start
          && execution_direction == EXEC_REVERSE)
-       end_stepping_range (ecs);
+       ;
       else
-       keep_going (ecs);
-
-      return;
+       {
+         keep_going (ecs);
+         return;
+       }
     }

   /* We stepped out of the stepping range.  */
@@ -7401,6 +7402,8 @@ process_event_stop_test (struct execution_control_state
*ecs)
                               "it's not the start of a statement");
        }
     }
+  else if (execution_direction == EXEC_REVERSE)
+    refresh_step_info = false;

   /* We aren't done stepping.

...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-01-12 11:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 10:09 [Bug gdb/29962] New: " vries at gcc dot gnu.org
2023-01-04 13:30 ` [Bug gdb/29962] " vries at gcc dot gnu.org
2023-01-04 17:18 ` vries at gcc dot gnu.org
2023-01-11  9:39 ` vries at gcc dot gnu.org
2023-01-11 10:03 ` vries at gcc dot gnu.org
2023-01-11 10:06 ` vries at gcc dot gnu.org
2023-01-11 10:08 ` vries at gcc dot gnu.org
2023-01-12 11:55 ` vries at gcc dot gnu.org [this message]
2023-01-12 16:30 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29962-4717-JXdV6BeSwv@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).