From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 5153B3858D35; Sat,  7 Jan 2023 22:13:31 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5153B3858D35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1673129611;
	bh=U6ZcRD7/PEJy6vz9dN9kYk5L2e46R2vREVihU3x/tZs=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=wM0sPbHdSHpxFIk59vV791C2W17b8KqufO7B8+tBmss8LjR+Pjp53Zeo7UtmSew9p
	 sViSOKIBDZKZPRFSqxyqx3kuHyJG2o7yjsGqSbZMkbzrNmcHjAI1uIvehxmXTn8CD/
	 K48RcYY7H2JD4coMXkHV7B3axjONZGvCeLPMIETk=
From: "jwakely.gcc at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug build/29966] Cannot build anymore for win32 thread model of gdb
Date: Sat, 07 Jan 2023 22:13:30 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: build
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jwakely.gcc at gmail dot com
X-Bugzilla-Status: WAITING
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-29966-4717-bHFpfwh0Rr@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-29966-4717@http.sourceware.org/bugzilla/>
References: <bug-29966-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29966

--- Comment #17 from Jonathan Wakely <jwakely.gcc at gmail dot com> ---
The relevant part of gdbsupport/config.log is:

configure:8963: checking for std::thread
configure:8980: x86_64-w64-mingw32-g++ -c  -g -O2      conftest.cpp >&5
configure:8980: $? =3D 0
configure:8987: result: yes

And that's exactly what I'd expect given the snippet shown in comment 14 ab=
ove.
So it defines CXX_STD_THREAD and then thread-pool.h does:

#if CXX_STD_THREAD
#include <thread>
#include <mutex>
#include <condition_variable>
#include <future>
#endif

But thread-pool.cc includes that after common-defs.h:

#include "common-defs.h"
#include "gdbsupport/thread-pool.h"

So _WIN32_WINNT is set before including thread-pool.h:

/* We don't support Windows versions before XP, so we define
   _WIN32_WINNT correspondingly to ensure the Windows API headers
   expose the required symbols.  */
#if defined (__MINGW32__) || defined (__CYGWIN__)
# ifdef _WIN32_WINNT
#  if _WIN32_WINNT < 0x0501
#   undef _WIN32_WINNT
#   define _WIN32_WINNT 0x0501
#  endif
# else
#  define _WIN32_WINNT 0x0501
# endif
#endif  /* __MINGW32__ || __CYGWIN__ */

So when thread-pool.h includes <mutex> it doesn't actually get a definition=
 of
std::mutex.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=