[Bug gdb/29999] Bogus error message printed when debuginfod doesn't find source file

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29999

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Aaron Merey <amerey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8cc96ee4169f631917d048cbaeec14ddf8ccb90d

commit 8cc96ee4169f631917d048cbaeec14ddf8ccb90d
Author: Aaron Merey <amerey@redhat.com>
Date:   Thu Feb 9 20:35:32 2023 -0500

    gdb/source: Fix open_source_file error handling

    open_source_file relies on errno to communicate the reason for a missing
    source file.

    open_source_file may also call debuginfod_find_source.  It is possible
    for debuginfod_find_source to set errno to a value unrelated to the
    reason for a failed download.

    This can result in bogus error messages being reported as the reason for
    a missing source file.  The following error message should instead be
    "No such file or directory":

      Temporary breakpoint 1, 0x00005555556f4de0 in main ()
      (gdb) list
      Downloading source file
/usr/src/debug/glibc-2.36-8.fc37.x86_64/elf/<built-in>
      1       /usr/src/debug/glibc-2.36-8.fc37.x86_64/elf/<built-in>: Directory
not empty.

    Fix this by having open_source_file return a negative errno if it fails
    to open a source file.  Use this value to generate the error message
    instead of errno.

    Approved-By: Tom Tromey <tom@tromey.com>
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29999

-- 
You are receiving this mail because:
You are on the CC list for the bug.