From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id C1E6A3858C66; Mon, 23 Jan 2023 15:49:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1E6A3858C66 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674488980; bh=x6IBxfaMuQYzVOWcd9Zr5wTSwullejq7BUsr68THAks=; h=From:To:Subject:Date:In-Reply-To:References:From; b=RnNJV/gxpiWfs4IZwcG21JhQFfRDH7AIZ9OWpken457d8JGuUlHv6INItmEO9absX jF+6+XZHCNYdblg3OazZpxyJiwzmPBv9InNMoRm6s6j97XDjmpvBjsG8bCcy3r7cwk fulHsNPELDbFHnuqOjMTNZFEDSBLW2Zt5ugE3XHc= From: "cvs-commit at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug tdep/30011] [gdb/tdep, aarch64] Incorrect frame address for last insn (leaf case) Date: Mon, 23 Jan 2023 15:49:40 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: tdep X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30011 --- Comment #2 from cvs-commit at gcc dot gnu.org --- The master branch has been updated by Tom de Vries : https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D29e09a42f1d1= af3d97652e54b6b3cac68cf61d15 commit 29e09a42f1d1af3d97652e54b6b3cac68cf61d15 Author: Tom de Vries Date: Mon Jan 23 16:49:36 2023 +0100 [gdb/tdep, aarch64] Fix frame address of last insn Consider the test-case test.c, compiled without debug info: ... void foo (const char *s) { } int main (void) { foo ("foo"); return 0; } ... Disassembly of foo: ... 0000000000400564 : 400564: d10043ff sub sp, sp, #0x10 400568: f90007e0 str x0, [sp, #8] 40056c: d503201f nop 400570: 910043ff add sp, sp, #0x10 400574: d65f03c0 ret ... Now, let's do "info frame" at each insn in foo, as well as printing $sp and $x29 (and strip the output of info frame to the first line, for brevity): ... $ gdb -q a.out Reading symbols from a.out... (gdb) b *foo Breakpoint 1 at 0x400564 (gdb) r Starting program: a.out Breakpoint 1, 0x0000000000400564 in foo () (gdb) display /x $sp 1: /x $sp =3D 0xfffffffff3a0 (gdb) display /x $x29 2: /x $x29 =3D 0xfffffffff3a0 (gdb) info frame Stack level 0, frame at 0xfffffffff3a0: (gdb) si 0x0000000000400568 in foo () 1: /x $sp =3D 0xfffffffff390 2: /x $x29 =3D 0xfffffffff3a0 (gdb) info frame Stack level 0, frame at 0xfffffffff3a0: (gdb) si 0x000000000040056c in foo () 1: /x $sp =3D 0xfffffffff390 2: /x $x29 =3D 0xfffffffff3a0 (gdb) info frame Stack level 0, frame at 0xfffffffff3a0: (gdb) si 0x0000000000400570 in foo () 1: /x $sp =3D 0xfffffffff390 2: /x $x29 =3D 0xfffffffff3a0 (gdb) info frame Stack level 0, frame at 0xfffffffff3a0: (gdb) si 0x0000000000400574 in foo () 1: /x $sp =3D 0xfffffffff3a0 2: /x $x29 =3D 0xfffffffff3a0 (gdb) info frame Stack level 0, frame at 0xfffffffff3b0: pc =3D 0x400574 in foo; saved pc =3D 0x40058c (gdb) si 0x000000000040058c in main () 1: /x $sp =3D 0xfffffffff3a0 2: /x $x29 =3D 0xfffffffff3a0 ... The "frame at" bit lists 0xfffffffff3a0 except at the last insn, where = it lists 0xfffffffff3b0. The frame address is calculated here in aarch64_make_prologue_cache_1: ... unwound_fp =3D get_frame_register_unsigned (this_frame, cache->framer= eg); if (unwound_fp =3D=3D 0) return; cache->prev_sp =3D unwound_fp + cache->framesize; ... For insns after the prologue, we have cache->framereg =3D=3D sp and cache->framesize =3D=3D 16, so unwound_fp + cache->framesize gives the = wrong answer once sp has been restored to entry value by the before-last insn. Fix this by detecting the situation that the sp has been restored. This fixes PRs tdep/30010 and tdep/30011. This also fixes the aarch64 FAILs in gdb.reverse/solib-precsave.exp and gdb.reverse/solib-reverse.exp I reported in PR gdb/PR29721. Tested on aarch64-linux. PR tdep/30010 PR tdep/30011 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30010 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30011 --=20 You are receiving this mail because: You are on the CC list for the bug.=