public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tdep/30012] [gdb/tdep, aarch64] fp and sp register aliases ignored
Date: Thu, 19 Jan 2023 13:05:12 +0000	[thread overview]
Message-ID: <bug-30012-4717-6Cri0pZxoa@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30012-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30012

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ea2f6fad7e104fb65da6a438bb0ec753210f1e90

commit ea2f6fad7e104fb65da6a438bb0ec753210f1e90
Author: Tom de Vries <tdevries@space.suse.cz>
Date:   Thu Jan 19 14:05:08 2023 +0100

    [gdb/tdep, aarch64] Remove fp and sp reg aliases, add x31 reg alias

    In aarch64-tdep.c we find these register aliases:
    ...
    {
      /* 64-bit register names.  */
      {"fp", AARCH64_FP_REGNUM},
      {"lr", AARCH64_LR_REGNUM},
      {"sp", AARCH64_SP_REGNUM},
    ...

    The sp alias is superfluous, because the canonical name of x31 is already
sp.

    The fp alias is superfluous, because it's already taken by the default
meaning
    of fp, assigned here in _initialize_frame_reg:
    ...
      user_reg_add_builtin ("fp", value_of_builtin_frame_fp_reg, NULL);
    ...

    Fix this by removing the fp and sp aliases.

    While we're at it, add an x31 alias for sp.

    Approved-By: Luis Machado <luis.machado@arm.com>

    Tested on aarch64-linux.
    PR tdep/30012
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30012

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-01-19 13:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 15:12 [Bug tdep/30012] New: " vries at gcc dot gnu.org
2023-01-19 12:38 ` [Bug tdep/30012] " vries at gcc dot gnu.org
2023-01-19 13:05 ` cvs-commit at gcc dot gnu.org [this message]
2023-01-19 13:06 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30012-4717-6Cri0pZxoa@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).