From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 5DDB438A90AE; Fri, 20 Jan 2023 16:43:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5DDB438A90AE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674232994; bh=if5AXqJxsjNW7xv0vHaZobTT/vlBf1aQuvjm3GnFKqQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=lheh9VUhQnlGMbKKLGEme3HNlphjU63KzfA11f+uq73TRwt6DEFT7ofQq3+Dp+sfM jzUqsmBj1ORwBZFwrHFr6etO5hvH8O2+j34FS37yK9JDsiJvyCzqSZr9pjPXU3kXlx qaTeVE3FaZ1TKFDAJnedEYaaUrDZGq0FxNEqREeg= From: "vries at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug tdep/30028] [gdb/tdep, x86_64] Epilogue unwinder preferred over dwarf unwinder based on gcc 4.4 Date: Fri, 20 Jan 2023 16:43:14 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: tdep X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: vries at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30028 --- Comment #6 from Tom de Vries --- (In reply to Tom de Vries from comment #5) > So, maybe we should just flip the switch on the default assumption. Like so: ... diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c index 76e843ecc35..86e12b4304a 100644 --- a/gdb/amd64-tdep.c +++ b/gdb/amd64-tdep.c @@ -2905,7 +2905,7 @@ amd64_stack_frame_destroyed_p struct compunit_symtab *cust; cust =3D find_pc_compunit_symtab (pc); - if (cust !=3D NULL && cust->epilogue_unwind_valid ()) + if (cust =3D=3D NULL || cust->epilogue_unwind_valid ()) return 0; if (target_read_memory (pc, &insn, 1)) diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index 580664d2ce5..46ad2913788 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -2222,7 +2222,7 @@ i386_stack_frame_destroyed_p struct compunit_symtab *cust; cust =3D find_pc_compunit_symtab (pc); - if (cust !=3D NULL && cust->epilogue_unwind_valid ()) + if (cust =3D=3D NULL || cust->epilogue_unwind_valid ()) return 0; if (target_read_memory (pc, &insn, 1)) ... --=20 You are receiving this mail because: You are on the CC list for the bug.=