From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 243C43858D20; Fri, 20 Jan 2023 16:24:33 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 243C43858D20
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1674231873;
	bh=VkNwAbGMZ3WYc7l1s1mtRIFKCuJCXoLmIZsnzfi9WNs=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=MaDFzNeN/NkeYyggMuQpIawmlAnMb/jtOmREWY1mE4Equ/+LBStqQc/cLnf30XTxF
	 UHqPMPzl2BZqQxyi6CbrnkjipN3LGobUGvGVKaMgHV50DCMg7bs4KbsxF2JWXTKRS8
	 nnb+L0FayqP5v0AktmJsyZDdUYe9hjLZQpQQNNSA=
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tdep/30028] [gdb/tdep, x86_64] Epilogue unwinder preferred over
 dwarf unwinder based on gcc 4.4
Date: Fri, 20 Jan 2023 16:24:32 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: tdep
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-30028-4717-fBREMscW1G@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-30028-4717@http.sourceware.org/bugzilla/>
References: <bug-30028-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30028

--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #4)
> (In reply to Tom de Vries from comment #2)
> > Here ( https://gcc.gnu.org/gcc-4.5/changes.html ) I read:
> > ...
> > GCC now generates unwind info also for epilogues.=20
> > ...
> > So, maybe this was fixed in gcc 4.5 ?
>=20
> OK, I think this is referring to:
> https://gcc.gnu.org/pipermail/gcc-patches/2009-May/261377.html which was
> committed as cd9c1ca866b6aa5041a352e0ed07ae5f91e235e5 .
>=20
> First tag to contain the commit: 4.5.0.

And, we already know this:
...
      if (gcc_4_minor >=3D 5)
        cust->set_epilogue_unwind_valid (true);
...

So we already scan the producer for
https://sourceware.org/pipermail/gdb-patches/2011-June/083429.html , and
crucially:
...
I find questionable this detection uses DWARF DW_AT_producer.  Therefore on
binaries with .eh_frame but no (DWARF) debug info the detection fails and
epilogue unwinders will get into affect.
...

So, that's what's happening.  We have dwarf apart from .eh_frame, and we do=
n't
use the .eh_frame info because we can't check that the producer is 4.5 or
older.

So, maybe we should just flip the switch on the default assumption.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=