From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id C11473858D1E; Mon, 30 Jan 2023 22:16:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C11473858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675116985; bh=U6D6FN7IwKTwAfsRuBu+xWFxPCgsM41uhUgWI1/bjZA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=ySVQGthRa7X20YTaBEXg+BKlZyW/7nibQqYjL+8MbKHjfSdWNlMibRu+SZTdgaHx6 5SD58St0V89dk6EXef9HjjP31ff3DKG/Z8f2D1geB+AmEeFDmPx4+wkGE+etPMtbS9 FYPoAJIQIWLohjwdffXIRgt3OmX5VBm1fz+KNEkQ= From: "tromey at sourceware dot org" To: gdb-prs@sourceware.org Subject: [Bug python/30044] Flawed logic when releasing values from all_values buffer Date: Mon, 30 Jan 2023 22:16:25 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: python X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: tromey at sourceware dot org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30044 --- Comment #6 from Tom Tromey --- I apparently knew about this problem in the relatively recent past: commit 42331a1ea2a13ce15ec202c5f0fbef3e5171253c Author: Tom Tromey Date: Fri Mar 13 17:39:52 2020 -0600 Change extension language pretty-printers to use value API This changes the extension language pretty-printers to use the value API. Note that new functions were needed, for both Guile and Python. Currently both languages always wrap values by removing the values from the value chain. This makes sense to avoid strange behavior with watchpoints, and to avoid excessive memory use. However, when printing, it's important to leave the passed-in value untouched, in case pretty-printing does nothing -- that way the caller can still access it. This was part of the val_print removal series. --=20 You are receiving this mail because: You are on the CC list for the bug.=