From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id ABAD03858D35; Tue, 23 May 2023 09:53:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ABAD03858D35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1684835636; bh=iel4CdI5PiN3oc63MmV7zPdfYtNbxrOVueObcJkQkPE=; h=From:To:Subject:Date:In-Reply-To:References:From; b=uDmk8dQlmNOtF5Jpr5HbgA80Q1dNggqtz+EfhGhY03+JDxpmpc12FkD0Gs0rwkc8p Ly5c7MnWOTh1hY/Qmdyw6F9OaQJ+3dCpsqVgE3joz64nI63k9OKq8fvwleu9Ry71Pd E4jRh6ZrBWFSGyACL6ieFIYPF6Drpew5/eXqp04s= From: "vries at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug tui/30056] double free when using reverse-search for a previous command and Ctrl-C Date: Tue, 23 May 2023 09:53:55 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: tui X-Bugzilla-Version: 12.1 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: vries at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30056 --- Comment #2 from Tom de Vries --- The simplest way of fixing this is: ... diff --git a/readline/readline/isearch.c b/readline/readline/isearch.c index 080ba3cbb9c..407c8b61543 100644 --- a/readline/readline/isearch.c +++ b/readline/readline/isearch.c @@ -882,7 +882,8 @@ _rl_isearch_callback (_rl_search_cxt *cxt) int c, r; c =3D _rl_search_getchar (cxt); - /* We might want to handle EOF here */ + if (c =3D=3D EOF) + return 1; r =3D _rl_isearch_dispatch (cxt, cxt->lastc); return (r <=3D 0) ? _rl_isearch_cleanup (cxt, r) : 0; ... but the question is if that sometimes skips _rl_isearch_cleanup while it shouldn't. --=20 You are receiving this mail because: You are on the CC list for the bug.=