public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug build/30098] Keep trying clang-format
Date: Wed, 08 Feb 2023 23:57:08 +0000	[thread overview]
Message-ID: <bug-30098-4717-J8awSCdb2j@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30098-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30098

--- Comment #7 from Tom Tromey <tromey at sourceware dot org> ---
> Probably a bug in clang-format?

Seems like it has to be, formatters ought to be idempotent.
Otherwise if we use it we will get a lot of commit churn.

> If we want to use an automated tool, we have to accept the tradeoff that some cases will be less nice, in exchange for convenience.

Yeah, I agree.  I just feel some things are too ugly.
I can probably live with most of the changes clang-format imposes,
but I am not sure that is true for all of them.

Also I found out that it doesn't format lambdas close to what we like.
It puts the opening brace at the wrong spot, so I wonder if maybe
we're missing a config item.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-02-08 23:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 19:57 [Bug build/30098] New: " tromey at sourceware dot org
2023-02-08 20:00 ` [Bug build/30098] " tromey at sourceware dot org
2023-02-08 20:05 ` tromey at sourceware dot org
2023-02-08 20:07 ` tromey at sourceware dot org
2023-02-08 20:09 ` tromey at sourceware dot org
2023-02-08 20:10 ` tromey at sourceware dot org
2023-02-08 20:32 ` simark at simark dot ca
2023-02-08 21:31 ` jan at vrany dot io
2023-02-08 22:27 ` sam at gentoo dot org
2023-02-08 23:57 ` tromey at sourceware dot org [this message]
2023-08-03 16:53 ` tromey at sourceware dot org
2025-01-12 19:52 ` tromey at sourceware dot org
2025-01-13  5:26 ` simon.marchi at polymtl dot ca
2025-01-14 11:12 ` jan at vrany dot io
2025-01-14 17:10 ` tromey at sourceware dot org
2025-01-14 23:27 ` tromey at sourceware dot org
2025-01-14 23:28 ` tromey at sourceware dot org
2025-01-14 23:31 ` tromey at sourceware dot org
2025-01-14 23:32 ` tromey at sourceware dot org
2025-01-14 23:34 ` tromey at sourceware dot org
2025-01-15  8:29 ` tankut.baris.aktemur at intel dot com
2025-01-15 15:40 ` simon.marchi at polymtl dot ca
2025-01-15 15:41 ` simon.marchi at polymtl dot ca
2025-01-15 16:51 ` simon.marchi at polymtl dot ca
2025-01-15 16:52 ` simon.marchi at polymtl dot ca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30098-4717-J8awSCdb2j@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).