[Bug build/30098] Keep trying clang-format

["tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30098

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
BTW there are a bunch of FIXMEs in the config file.
I don't really know how the penalty system works so
maybe that can be improved too.

Sometimes clang-format makes bad decisions.  One example
I'm looking at is if you have an 'if' that is a series of
clauses joined by '&&', sometimes it is clearest to put
each such clause on its own line.  However clang-format does this:

@@ -194,10 +193,8 @@ eq_bfd (const void *a, const void *b)
     = (const struct gdb_bfd_cache_search *) b;
   struct gdb_bfd_data *gdata = (struct gdb_bfd_data *) bfd_usrdata (abfd);

-  return (gdata->mtime == s->mtime
-         && gdata->size == s->size
-         && gdata->inode == s->inode
-         && gdata->device_id == s->device_id
+  return (gdata->mtime == s->mtime && gdata->size == s->size
+         && gdata->inode == s->inode && gdata->device_id == s->device_id
          && strcmp (bfd_get_filename (abfd), s->filename) == 0);
 }

-- 
You are receiving this mail because:
You are on the CC list for the bug.