From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 6AC59385840D; Wed, 15 Feb 2023 21:01:39 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6AC59385840D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1676494899;
	bh=/16c1D0Z+LhqplBiPf1vizVNNebFR19dxbSj9kNjQ7M=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=ODKO5kL1frwFXGSNGkmf6chi/rIC26hGuR4I+qpj2vS+GuDgpRNqQMKfHZkhJnOw2
	 7nt49co5ww5wZQd7HwCUbQazNlMia3rwZBWs1A6TD4tqLEe80BA83zfw9Ezo5oZ3n8
	 MexKqdI64EkSltfEkDM/wtAUcxPcim/PhqKOg+5A=
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/30105] ptype of internal convenience functions is broken
Date: Wed, 15 Feb 2023 21:01:39 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: gdb
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: pedro at palves dot net
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-30105-4717-X6d5Io7QGw@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-30105-4717@http.sourceware.org/bugzilla/>
References: <bug-30105-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30105

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gn=
u.org> ---
The master branch has been updated by Pedro Alves <palves@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D751495be92b2=
b319fb66ce4e12b562a0e27c15fe

commit 751495be92b2b319fb66ce4e12b562a0e27c15fe
Author: Pedro Alves <pedro@palves.net>
Date:   Fri Feb 10 11:55:00 2023 +0000

    Make "ptype INTERNAL_FUNCTION" in Ada print like other languages

    Currently, printing the type of an internal function in Ada shows
    double <>s, like:

     (gdb) with language ada -- ptype $_isvoid
     type =3D <<internal function>>

    while all other languages print it with a single <>, like:

     (gdb) with language c -- ptype $_isvoid
     type =3D <internal function>

    I don't think there's a reason that Ada needs to be different.  We
    currently print the double <>s because we take this path in
    ada_print_type:

        switch (type->code ())
          {
          default:
            gdb_printf (stream, "<");
            c_print_type (type, "", stream, show, level, language_ada, flag=
s);
            gdb_printf (stream, ">");
            break;

    ... and the type's name already has the <>s.

    Fix this by simply adding an early check for
    TYPE_CODE_INTERNAL_FUNCTION.

    Approved-By: Andrew Burgess <aburgess@redhat.com>
    Approved-By: Tom Tromey <tom@tromey.com>
    Change-Id: Ic2b6527b9240a367471431023f6e27e6daed5501
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30105

--=20
You are receiving this mail because:
You are on the CC list for the bug.=