From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 6115A388302F; Mon, 13 Feb 2023 14:16:05 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6115A388302F
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1676297765;
	bh=9sjUMuLSL2XseOFuvIz6zsEKdcevasKFmQTmWRcPb7Y=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=AXTcIqOWFQismuHCmmpwoutGrnQd0xyhc0pT/dojmfk01Yqanyy9iO3jNQdlLj8ZQ
	 QrzRUbR3aFYg1BPTCTTljkoyHU//MQJAdJEEnKyce/gMbZ1sqaL22Adt2FqaEN2mfe
	 4cNOyJ5uok3R/NUHmeHEQE3nUKyvSZ5JGsR1GPEA=
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug build/30108] gdb info docs fail to build when configured
 --with-system-readlne
Date: Mon, 13 Feb 2023 14:16:04 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: build
X-Bugzilla-Version: 13.1
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: keiths at redhat dot com
X-Bugzilla-Target-Milestone: 13.1
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-30108-4717-yXgBalbD9l@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-30108-4717@http.sourceware.org/bugzilla/>
References: <bug-30108-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30108

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gn=
u.org> ---
The master branch has been updated by Keith Seitz <kseitz@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D14d0e6818a02=
2b72c265f15f63c8ccc2fc8c302a

commit 14d0e6818a022b72c265f15f63c8ccc2fc8c302a
Author: Keith Seitz <keiths@redhat.com>
Date:   Mon Feb 13 06:14:40 2023 -0800

    Fix doc build dependencies for --with-system-readline

    PR build/30108 concerns building gdb documentation with
    --with-sytem-readline.  If the in-tree readline directory is
    missing, though, the docs will fail to build:

    make[4]: Entering directory
'/home/keiths/work/readline-doc-issue/linux/gdb/doc'
    make[4]: *** No rule to make target
'../../../src/gdb/doc/../../readline/readline/doc/rluser.texi', needed by
'gdb.info'.  Stop.

    The listed file (and hsuser.texi) are conditionally included by
gdb.texinfo.
    When system readline is used, gdb/configure.ac will leave
    READLINE_TEXI_INCFLAGS empty, causing doc/Makefile.in to output a line =
to
    $BUILD/doc/GDBvn.texi with "@set SYSTEM_READLINE".  This surpresses the
    inclusion of the missing files. They are not needed or used in this
    scenario.

    However, GDB_DOC_SOURCE_INCLUDES always lists these two files as
dependencies,
    thus provoking the build error whenever readline/ is missing.

    This patch fixes this by creating (essentially) a conditional setting of
the
    dependencies to be included from readline.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=