public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug remote/30129] Thread exited messages are missing for remote targets
Date: Thu, 09 Mar 2023 11:31:22 +0000	[thread overview]
Message-ID: <bug-30129-4717-OzHOdHsL2R@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30129-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30129

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=89702edd933a5595557bcd9cc4a0dcc3262226d4

commit 89702edd933a5595557bcd9cc4a0dcc3262226d4
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Mar 9 12:31:26 2023 +0100

    [gdb/testsuite] Fix gdb.threads/thread-specific-bp.exp on native-gdbserver

    With test-case gdb.threads/thread-specific-bp.exp and target board
    native-gdbserver I run into:
    ...
    (gdb) PASS: gdb.threads/thread-specific-bp.exp: non_stop=off: thread 1
selected
    continue^M
    Continuing.^M
    Thread-specific breakpoint 3 deleted - thread 2 no longer in the thread
list.^M
    ^M
    Thread 1 "thread-specific" hit Breakpoint 4, end () at \
      thread-specific-bp.c:29^M
    29      }^M
    (gdb) FAIL: gdb.threads/thread-specific-bp.exp: non_stop=off: \
      continue to end (timeout)
    ...

    The problem is that the test-case tries to match the "[Thread ... exited]"
    message which we do see with native testing:
    ...
    Continuing.^M
    [Thread 0x7ffff746e700 (LWP 7047) exited]^M
    Thread-specific breakpoint 3 deleted - thread 2 no longer in the thread
list.^M
    ...

    The fact that the message is missing was reported as PR remote/30129.

    We could add a KFAIL for this, but the functionality the test-case is
trying
    to test has nothing to do with the message, so it should pass.  I only
added
    matching of the message in commit 2e5843d87c4 ("[gdb/testsuite] Fix
    gdb.threads/thread-specific-bp.exp") to handle a race, not realizing doing
so
    broke testing on native-gdbserver.

    Fix this by matching the "Thread-specific breakpoint $decimal deleted"
message
    instead.

    Tested on x86_64-linux.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2023-03-09 11:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16 15:38 [Bug remote/30129] New: " aburgess at redhat dot com
2023-03-09 11:31 ` cvs-commit at gcc dot gnu.org [this message]
2023-08-23  9:12 ` [Bug remote/30129] " cvs-commit at gcc dot gnu.org
2023-08-23  9:14 ` aburgess at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30129-4717-OzHOdHsL2R@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).