[Bug symtab/30164] Restructure symbol domains

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30164

--- Comment #6 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=974b36c2ae2b351d022cc62579656f722da6e17a

commit 974b36c2ae2b351d022cc62579656f722da6e17a
Author: Tom Tromey <tom@tromey.com>
Date:   Thu Mar 2 07:44:11 2023 -0700

    Use the new symbol domains

    This patch changes the DWARF reader to use the new symbol domains.  It
    also adjusts many bits of associated code to adapt to this change.

    The non-DWARF readers are updated on a best-effort basis.  This is
    somewhat simpler since most of them only support C and C++.  I have no
    way to test a few of these.

    I went back and forth a few times on how to handle the "tag"
    situation.  The basic problem is that C has a special namespace for
    tags, which is separate from the type namespace.  Other languages
    don't do this.  So, the question is, should a DW_TAG_structure_type
    end up in the tag domain, or the type domain, or should it be
    language-dependent?

    I settled on making it language-dependent using a thought experiment.
    Suppose there was a Rust compiler that only emitted nameless
    DW_TAG_structure_type objects, and specified all structure type names
    using DW_TAG_typedef.  This DWARF would be correct, in that it
    faithfully represents the source language -- but would not work with a
    purely struct-domain implementation in gdb.  Therefore gdb would be
    wrong.

    Now, this approach is a little tricky for C++, which uses tags but
    also enters a typedef for them.  I notice that some other readers --
    like stabsread -- actually emit a typedef symbol as well.  And, I
    think this is a reasonable approach.  It uses more memory, but it
    makes the internals simpler.  However, DWARF never did this for
    whatever reason, and so in the interest of keeping the series slightly
    shorter, I've left some C++-specific hacks in place here.

    Note that this patch includes language_minimal as a language that uses
    tags.  I did this to avoid regressing gdb.dwarf2/debug-names-tu.exp,
    which doesn't specify the language for a type unit.  Arguably this
    test case is wrong.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30164

-- 
You are receiving this mail because:
You are on the CC list for the bug.